You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by jp...@apache.org on 2015/06/30 11:16:03 UTC
svn commit: r1688409 - in /lucene/dev/trunk/lucene: ./
queryparser/src/java/org/apache/lucene/queryparser/xml/
queryparser/src/java/org/apache/lucene/queryparser/xml/builders/
queryparser/src/test/org/apache/lucene/queryparser/xml/
sandbox/src/java/org...
Author: jpountz
Date: Tue Jun 30 09:16:02 2015
New Revision: 1688409
URL: http://svn.apache.org/r1688409
Log:
LUCENE-6633: Remove DuplicateFilter.
Removed:
lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/builders/DuplicateFilterBuilder.java
lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/DuplicateFilterQuery.xml
lucene/dev/trunk/lucene/sandbox/src/java/org/apache/lucene/sandbox/queries/DuplicateFilter.java
lucene/dev/trunk/lucene/sandbox/src/test/org/apache/lucene/sandbox/queries/DuplicateFilterTest.java
Modified:
lucene/dev/trunk/lucene/CHANGES.txt
lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java
lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestParser.java
Modified: lucene/dev/trunk/lucene/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/CHANGES.txt?rev=1688409&r1=1688408&r2=1688409&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/CHANGES.txt (original)
+++ lucene/dev/trunk/lucene/CHANGES.txt Tue Jun 30 09:16:02 2015
@@ -268,6 +268,10 @@ Changes in Backwards Compatibility Polic
always includes deleted docs, so you have to check for deleted documents on
top of the iterator. (Adrien Grand)
+* LUCENE-6633: DuplicateFilter has been deprecated and will be removed in 6.0.
+ DiversifiedTopDocsCollector can be used instead with a maximum number of hits
+ per key equal to 1. (Adrien Grand)
+
======================= Lucene 5.2.1 =======================
Bug Fixes
Modified: lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java?rev=1688409&r1=1688408&r2=1688409&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java (original)
+++ lucene/dev/trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/xml/CorePlusExtensionsParser.java Tue Jun 30 09:16:02 2015
@@ -49,7 +49,6 @@ public class CorePlusExtensionsParser ex
private CorePlusExtensionsParser(String defaultField, Analyzer analyzer, QueryParser parser) {
super(defaultField, analyzer, parser);
- queryFactory.addBuilder("DuplicateFilter", new DuplicateFilterBuilder());
String fields[] = {"contents"};
queryFactory.addBuilder("LikeThisQuery", new LikeThisQueryBuilder(analyzer, fields));
queryFactory.addBuilder("BoostingQuery", new BoostingQueryBuilder(queryFactory));
Modified: lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestParser.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestParser.java?rev=1688409&r1=1688408&r2=1688409&view=diff
==============================================================================
--- lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestParser.java (original)
+++ lucene/dev/trunk/lucene/queryparser/src/test/org/apache/lucene/queryparser/xml/TestParser.java Tue Jun 30 09:16:02 2015
@@ -186,14 +186,6 @@ public class TestParser extends LuceneTe
dumpResults("Cached filter", q, 5);
}
- public void testDuplicateFilterQueryXML() throws ParserException, IOException {
- List<LeafReaderContext> leaves = searcher.getTopReaderContext().leaves();
- Assume.assumeTrue(leaves.size() == 1);
- Query q = parse("DuplicateFilterQuery.xml");
- int h = searcher.search(q, 1000).totalHits;
- assertEquals("DuplicateFilterQuery should produce 1 result ", 1, h);
- }
-
public void testNumericRangeQueryQueryXML() throws ParserException, IOException {
Query q = parse("NumericRangeQueryQuery.xml");
dumpResults("NumericRangeQuery", q, 5);