You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Brett Okken <br...@gmail.com> on 2021/02/17 16:48:16 UTC
make gzip deflate buffer size configurable
The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
Are there any objections to making that size configurable in
GzipParameters? If that is acceptable, I can create a PR with the
changes.
Thanks,
Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: make gzip deflate buffer size configurable
Posted by Brett Okken <br...@gmail.com>.
https://issues.apache.org/jira/browse/COMPRESS-566
https://github.com/apache/commons-compress/pull/168
Thanks,
Brett
On Wed, Feb 17, 2021 at 1:23 PM Gary Gregory <ga...@gmail.com> wrote:
>
> Yes in both cases is safest.
>
> Gary
>
> On Wed, Feb 17, 2021, 14:17 Brett Okken <br...@gmail.com> wrote:
>
> > 512 is also the default in GZIPInputStream, but I agree that it seems
> > quite small, which is why I want to be able to adjust it :)
> >
> > I have not contributed to this project in the past. Does this type of
> > issue just need a PR, or should I log a JIRA also?
> >
> > Brett
> >
> > On Wed, Feb 17, 2021 at 1:04 PM Gary Gregory <ga...@gmail.com>
> > wrote:
> > >
> > > Sounds good to me. Also the default seems small, or is that a standard
> > size
> > > for Gzip, otherwise 4k or 8k seems better.
> > >
> > > Gary
> > >
> > >
> > > On Wed, Feb 17, 2021, 11:48 Brett Okken <br...@gmail.com>
> > wrote:
> > >
> > > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> > > > Are there any objections to making that size configurable in
> > > > GzipParameters? If that is acceptable, I can create a PR with the
> > > > changes.
> > > >
> > > > Thanks,
> > > > Brett
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > > For additional commands, e-mail: dev-help@commons.apache.org
> > > >
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: make gzip deflate buffer size configurable
Posted by Gary Gregory <ga...@gmail.com>.
Yes in both cases is safest.
Gary
On Wed, Feb 17, 2021, 14:17 Brett Okken <br...@gmail.com> wrote:
> 512 is also the default in GZIPInputStream, but I agree that it seems
> quite small, which is why I want to be able to adjust it :)
>
> I have not contributed to this project in the past. Does this type of
> issue just need a PR, or should I log a JIRA also?
>
> Brett
>
> On Wed, Feb 17, 2021 at 1:04 PM Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > Sounds good to me. Also the default seems small, or is that a standard
> size
> > for Gzip, otherwise 4k or 8k seems better.
> >
> > Gary
> >
> >
> > On Wed, Feb 17, 2021, 11:48 Brett Okken <br...@gmail.com>
> wrote:
> >
> > > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> > > Are there any objections to making that size configurable in
> > > GzipParameters? If that is acceptable, I can create a PR with the
> > > changes.
> > >
> > > Thanks,
> > > Brett
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: make gzip deflate buffer size configurable
Posted by Brett Okken <br...@gmail.com>.
512 is also the default in GZIPInputStream, but I agree that it seems
quite small, which is why I want to be able to adjust it :)
I have not contributed to this project in the past. Does this type of
issue just need a PR, or should I log a JIRA also?
Brett
On Wed, Feb 17, 2021 at 1:04 PM Gary Gregory <ga...@gmail.com> wrote:
>
> Sounds good to me. Also the default seems small, or is that a standard size
> for Gzip, otherwise 4k or 8k seems better.
>
> Gary
>
>
> On Wed, Feb 17, 2021, 11:48 Brett Okken <br...@gmail.com> wrote:
>
> > The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> > Are there any objections to making that size configurable in
> > GzipParameters? If that is acceptable, I can create a PR with the
> > changes.
> >
> > Thanks,
> > Brett
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: make gzip deflate buffer size configurable
Posted by Gary Gregory <ga...@gmail.com>.
Sounds good to me. Also the default seems small, or is that a standard size
for Gzip, otherwise 4k or 8k seems better.
Gary
On Wed, Feb 17, 2021, 11:48 Brett Okken <br...@gmail.com> wrote:
> The deflateBuffer in GzipCompressorOutputStream is hardcoded to 512.
> Are there any objections to making that size configurable in
> GzipParameters? If that is acceptable, I can create a PR with the
> changes.
>
> Thanks,
> Brett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>