You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2026/05/12 04:03:52 UTC
[PR] fix(lifecycle): resolve maintenance port mismatch and harden return path [superset-kubernetes-operator]
villebro opened a new pull request, #47:
URL: https://github.com/apache/superset-kubernetes-operator/pull/47
## Summary
Fixes issues identified in post-merge review of #46:
- **Port mismatch (high):** When the web-server container port is customized (e.g., 9090), the maintenance nginx was still hardcoded to listen on 8088. Traffic switched to maintenance pods would hit a port where nothing is listening. Now `renderNginxConf()` and the maintenance Deployment both use the resolved web-server container port.
- **Return-path failure window (medium):** If maintenance resource deletion failed after `MaintenanceActive` was set false, the Service could still select maintenance pods whose Deployment was already gone. Fixed by reordering: the Service selector now switches *before* maintenance resources are deleted. Deletion is best-effort since the resources are parent-owned (GC handles them regardless).
- **Stale docs (medium):** Updated AGENTS.md, architecture/internals, architecture/overview, user-guide/lifecycle, and index.md to reflect the new parent-owned Service design, removal of `SupersetMaintenancePage` CRD, and three-task lifecycle model.
- **Missing regression tests (low):** Added tests for custom port propagation, selector switching based on `MaintenanceActive`, and port resolution edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(lifecycle): resolve maintenance port mismatch and harden return path [superset-kubernetes-operator]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #47:
URL: https://github.com/apache/superset-kubernetes-operator/pull/47#issuecomment-4427278686
## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/47?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `33.33333%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.54%. Comparing base ([`99aff96`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/99aff965ff4ef9ae022a89dc9533e963d9d28cfd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c202304`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/c202304bdc82af6282ace97bbe0be33f18af4892?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/47?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [internal/controller/maintenance.go](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/47?src=pr&el=tree&filepath=internal%2Fcontroller%2Fmaintenance.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvY29udHJvbGxlci9tYWludGVuYW5jZS5nbw==) | 20.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/47?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/47?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(lifecycle): resolve maintenance port mismatch and harden return path [superset-kubernetes-operator]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #47:
URL: https://github.com/apache/superset-kubernetes-operator/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org