You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/15 09:28:51 UTC
[GitHub] [druid] agricenko commented on a change in pull request #9854: Integration Tests.
agricenko commented on a change in pull request #9854:
URL: https://github.com/apache/druid/pull/9854#discussion_r425680092
##########
File path: integration-tests/pom.xml
##########
@@ -446,61 +450,7 @@
</suiteXmlFiles>
</configuration>
</plugin>
- <plugin>
- <groupId>de.thetaphi</groupId>
- <artifactId>forbiddenapis</artifactId>
- <configuration>
- <signaturesFiles>
- <!-- Needed because of https://github.com/policeman-tools/forbidden-apis/issues/126 -->
- <signaturesFile>../codestyle/joda-time-forbidden-apis.txt</signaturesFile>
- <signaturesFile>../codestyle/druid-forbidden-apis.txt</signaturesFile>
- </signaturesFiles>
- </configuration>
- </plugin>
- </plugins>
- </build>
- </profile>
- <profile>
- <id>int-tests-config-file</id>
- <build>
- <plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-failsafe-plugin</artifactId>
- <executions>
- <execution>
- <id>integration-tests</id>
- <phase>integration-test</phase>
- <goals>
- <goal>integration-test</goal>
- <goal>verify</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <properties>
- <property>
- <name>testrunfactory</name>
- <value>org.testng.DruidTestRunnerFactory</value>
- </property>
- </properties>
- <argLine>
- -Duser.timezone=UTC
- -Dfile.encoding=UTF-8
- -Ddruid.test.config.type=configFile
- -Ddruid.test.config.configFile=${env.CONFIG_FILE}
- -Ddruid.client.https.trustStorePath=client_tls/truststore.jks
- -Ddruid.client.https.trustStorePassword=druid123
- -Ddruid.client.https.keyStorePath=client_tls/client.jks
- -Ddruid.client.https.certAlias=druid
- -Ddruid.client.https.keyManagerPassword=druid123
- -Ddruid.client.https.keyStorePassword=druid123
- </argLine>
- <suiteXmlFiles>
- <suiteXmlFile>src/test/resources/testng.xml</suiteXmlFile>
- </suiteXmlFiles>
- </configuration>
- </plugin>
+
Review comment:
I dont understand the reason of this Profile. We can run tests with integration-tests profile and add 3 arguments: "skip.start.docker=true" "skip.stop.docker=true" "skip.build.docker=true" to get the same behaviour as with "int-tests-config-file" profile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org