[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #84: [WIP] - Guest network: Egress rules tab

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #84: [WIP] - Guest network: Egress rules tab
URL: https://github.com/apache/cloudstack-primate/pull/84#discussion_r362689727
 
 

 ##########
 File path: src/config/section/network.js
 ##########
 @@ -186,14 +187,20 @@ export default {
       columns: ['ipaddress', 'state', 'associatednetworkname', 'virtualmachinename', 'allocated', 'account', 'zonename'],
       details: ['ipaddress', 'id', 'associatednetworkname', 'virtualmachinename', 'networkid', 'issourcenat', 'isstaticnat', 'virtualmachinename', 'vmipaddress', 'vlan', 'allocated', 'account', 'zonename'],
       tabs: [{
-        name: 'configure',
-        component: () => import('@/views/network/IpConfigure.vue')
+        name: 'details',
+        component: () => import('@/components/view/DetailsTab.vue')
+      }, {
+        name: 'Firewall',
+        component: () => import('@/views/network/FirewallRules.vue')
+      }, {
+        name: 'Port Forwarding',
+        component: () => import('@/views/network/PortForwarding.vue')
+      }, {
+        name: 'Load Balancing',
 
 Review comment:
   @RitchieVincent add the `show()` methods for all these tabs, as discussed and described earlier see the individual issues tickets on what condition to check (for example, 'Firewall' in case of Firewall tab etc). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services