You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/10 12:31:14 UTC
[GitHub] [dubbo-go] cjphaha opened a new pull request #1313: [WIP] Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
cjphaha opened a new pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313
* 删除 protocol/dubbo3/protoc-gen-dubbo3 和 protocol/grpc/protoc-gen-dubbo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1313: Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1313: Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313#issuecomment-881801446
这个pr先放着，暂时不急着合并
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1313: [WIP] Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313#issuecomment-877638273
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1313](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35abbe1) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/968650f658b63c11bb0409897d29c57b91cfaf50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (968650f) will **decrease** coverage by `2.37%`.
> The diff coverage is `56.67%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1313 +/- ##
==========================================
- Coverage 59.53% 57.15% -2.38%
==========================================
Files 259 268 +9
Lines 12737 14579 +1842
==========================================
+ Hits 7583 8333 +750
- Misses 4199 5329 +1130
+ Partials 955 917 -38
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/available\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYXZhaWxhYmxlX2NsdXN0ZXJfaW52b2tlci5nbw==) | `73.33% <ø> (+6.66%)` | :arrow_up: |
| [cluster/cluster\_impl/broadcast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYnJvYWRjYXN0X2NsdXN0ZXJfaW52b2tlci5nbw==) | `80.00% <ø> (+3.52%)` | :arrow_up: |
| [cluster/cluster\_impl/failfast\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGZhc3RfY2x1c3Rlcl9pbnZva2VyLmdv) | `71.42% <ø> (+4.76%)` | :arrow_up: |
| [cluster/cluster\_impl/mock\_cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvbW9ja19jbHVzdGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [cluster/loadbalance/random.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9yYW5kb20uZ28=) | `100.00% <ø> (ø)` | |
| [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/cluster\_interceptor.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyX2ludGVyY2VwdG9yLmdv) | `0.00% <0.00%> (ø)` | |
| [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | |
| [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | |
| ... and [409 more](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [52deca0...35abbe1](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha commented on pull request #1313: Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313#issuecomment-881421505
> Is it ready for merge? If not make it draft pls.
now it is ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1313: Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313#issuecomment-877638273
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1313](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35abbe1) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/3906343fa1be4d1a4e3e5f1c0dd5e2383d3448c2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3906343) will **increase** coverage by `2.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 35abbe1 differs from pull request most recent head 6117822. Consider uploading reports for the commit 6117822 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1313 +/- ##
==========================================
+ Coverage 54.91% 57.15% +2.24%
==========================================
Files 272 268 -4
Lines 14753 14579 -174
==========================================
+ Hits 8101 8333 +232
+ Misses 5778 5329 -449
- Partials 874 917 +43
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `86.36% <0.00%> (-13.64%)` | :arrow_down: |
| [filter/generic/service\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL2dlbmVyaWMvc2VydmljZV9maWx0ZXIuZ28=) | `64.91% <0.00%> (-12.64%)` | :arrow_down: |
| [protocol/dubbo/hessian2/hessian\_request.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaGVzc2lhbjIvaGVzc2lhbl9yZXF1ZXN0Lmdv) | `57.74% <0.00%> (-7.97%)` | :arrow_down: |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `61.76% <0.00%> (-6.81%)` | :arrow_down: |
| [config\_center/file/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9maWxlL2ltcGwuZ28=) | `50.00% <0.00%> (-5.48%)` | :arrow_down: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `68.65% <0.00%> (-5.19%)` | :arrow_down: |
| [config/remote\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlbW90ZV9jb25maWcuZ28=) | `67.74% <0.00%> (-4.68%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.85% <0.00%> (-3.71%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.76% <0.00%> (-3.20%)` | :arrow_down: |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `77.96% <0.00%> (-2.74%)` | :arrow_down: |
| ... and [57 more](https://codecov.io/gh/apache/dubbo-go/pull/1313/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3906343...6117822](https://codecov.io/gh/apache/dubbo-go/pull/1313?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha commented on pull request #1313: [WIP] Remove protoc-gen-dubbo & protoc-gen-dubbo3 tool
Posted by GitBox <gi...@apache.org>.
cjphaha commented on pull request #1313:
URL: https://github.com/apache/dubbo-go/pull/1313#issuecomment-878848550
> Is it ready for merge? If not make it draft pls.
ok~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org