You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (Jira)" <ji...@apache.org> on 2019/09/26 23:06:00 UTC
[jira] [Resolved] (IMPALA-2312) Timing bug in both
MonotonicStopWatch and StopWatch
[ https://issues.apache.org/jira/browse/IMPALA-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Armstrong resolved IMPALA-2312.
-----------------------------------
Fix Version/s: Impala 3.4.0
Resolution: Fixed
> Timing bug in both MonotonicStopWatch and StopWatch
> ---------------------------------------------------
>
> Key: IMPALA-2312
> URL: https://issues.apache.org/jira/browse/IMPALA-2312
> Project: IMPALA
> Issue Type: Bug
> Components: Backend
> Affects Versions: Impala 2.2.4
> Reporter: Henry Robinson
> Assignee: Tim Armstrong
> Priority: Minor
> Fix For: Impala 3.4.0
>
>
> Both {{MonotonicStopWatch}} and {{StopWatch}} underestimate the total time if the stopwatch is running while {{ElapsedTime()}} is called. For example:
> {code}
> uint64_t ElapsedTime() const {
> if (!running_) return total_time_;
> timespec end;
> clock_gettime(CLOCK_MONOTONIC, &end);
> // Should include total_time_, but does not
> return (end.tv_sec - start_.tv_sec) * 1000L * 1000L * 1000L +
> (end.tv_nsec - start_.tv_nsec);
> }
> {code}
> The effect is that we could have:
> {code}
> MonotonicStopWatch sw;
> sw.Start();
> sw.Stop();
> uint64_t total = sw.ElapsedTime();
> sw.Start();
> // With the bug, this could fail.
> ASSERT_GE(sw.ElapsedTime(), total);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org