[GitHub] [incubator-pekko-sbt-paradox] mdedetrich commented on a diff in pull request #10: setup publishing to apache nexus snapshots

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #10:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/10#discussion_r1101193755


##########
.github/workflows/publish.yml:
##########
@@ -0,0 +1,30 @@
+name: Publish
+
+on:
+  push:
+    branches: [ "main" ]
+
+jobs:
+  sbt:
+    name: Publish to apache nexus
+    runs-on: ubuntu-20.04
+    if: github.repository == 'apache/incubator-pekko-sbt-paradox'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 100
+
+      - name: Set up JDK 8
+        uses: olafurpg/setup-scala@v13
+        with:
+          java-version: adopt@1.8
+
+      - name: Publish
+        run: |-
+          sbt publish
+        env:
+          PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
+          PGP_SECRET: ${{ secrets.PGP_SECRET }}
+          SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}

Review Comment:
   The environment variables are wrong, see https://github.com/apache/incubator-pekko/blob/main/.github/workflows/publish-nightly.yml#L62-L64



##########
.github/workflows/publish.yml:
##########
@@ -0,0 +1,30 @@
+name: Publish
+
+on:
+  push:
+    branches: [ "main" ]
+
+jobs:
+  sbt:
+    name: Publish to apache nexus
+    runs-on: ubuntu-20.04
+    if: github.repository == 'apache/incubator-pekko-sbt-paradox'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 100
+
+      - name: Set up JDK 8
+        uses: olafurpg/setup-scala@v13
+        with:
+          java-version: adopt@1.8
+
+      - name: Publish
+        run: |-
+          sbt publish
+        env:
+          PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}

Review Comment:
   Is this is just copied from somewhere else or are you intended to release signed artifacts for now? Just asking because its not exactly clear we will be releasing signed artifacts via CI (this is especially the case if the plugin will do a proper release).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org