[PR] Pass impersonation_chain to the Dataflow trigger for Beam Java/Python operators [airflow]

["afonsojanu (via GitHub)" <gi...@apache.org>]

afonsojanu opened a new pull request, #72210:
URL: https://github.com/apache/airflow/pull/72210

   Fixes #72135
   
   BeamRunJavaPipelineOperator and BeamRunPythonPipelineOperator both use `self.dataflow_config.impersonation_chain` when running the pipeline directly, but when deferrable mode is on and they build `trigger_args` for `DataflowJobStatusTrigger` / `DataflowJobStateCompleteTrigger`, that value never gets passed through. So a deferred task ends up polling Dataflow for completion with whatever credentials the worker has, not the impersonated account the operator was configured with.
   
   Both trigger classes already accept `impersonation_chain` in their constructor (see `airflow/providers/google/cloud/triggers/dataflow.py`), so this is just a matter of including it in the dict the operators build.
   
   While looking at this I noticed the exact same pattern shows up in both operators, the Java one that the issue reports and the Python one that wasn't reported but has the identical bug, so I fixed both.
   
   I added a test for each operator asserting the trigger it raises actually carries the configured impersonation_chain. I couldn't run the full provider test suite locally since it needs the breeze dev environment, but I verified the fix against the real installed package by patching in the modified module and driving it through the exact same code path the tests exercise, confirming it fails without the change (impersonation_chain comes through as None) and passes with it.
   
   Ran ruff on both changed files with no issues.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pass impersonation_chain to the Dataflow trigger for Beam Java/Python operators [airflow]

["shahar1 (via GitHub)" <gi...@apache.org>]

shahar1 commented on PR #72210:
URL: https://github.com/apache/airflow/pull/72210#issuecomment-5734420395

   Closing in favor of https://github.com/apache/airflow/pull/72146


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pass impersonation_chain to the Dataflow trigger for Beam Java/Python operators [airflow]

["boring-cyborg[bot] (via GitHub)" <gi...@apache.org>]

boring-cyborg[bot] commented on PR #72210:
URL: https://github.com/apache/airflow/pull/72210#issuecomment-5455277582

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Pass impersonation_chain to the Dataflow trigger for Beam Java/Python operators [airflow]

["shahar1 (via GitHub)" <gi...@apache.org>]

shahar1 closed pull request #72210: Pass impersonation_chain to the Dataflow trigger for Beam Java/Python operators
URL: https://github.com/apache/airflow/pull/72210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org