You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by dlaboss <gi...@git.apache.org> on 2017/03/15 16:46:35 UTC
[GitHub] incubator-edgent pull request #299: [WIP] [COMMENTS?] [Edgent-112] cleanup J...

GitHub user dlaboss opened a pull request:

    https://github.com/apache/incubator-edgent/pull/299

    [WIP] [COMMENTS?] [Edgent-112] cleanup JobMonitorApp

    As noted in the JIRA there are other issues with the class as well.
    
    - migrate submitApplication() and closeJob() to new utils.ExecutionMgmt
      - not sure about the new api:utils for this class.  Originally had it in a runtime.utils but that didn't seem right (logically it's just convenience over some api defined services), then moved it to api:execution.utils but that introduced circular dependency, so created api:utils and put it there.  Is the new api:utils OK?
    - change ApplicationServiceMXBean.submit to return the created job's id
    - add JobMonitorApp.createAndRegister (the idiom used elsewhere)
    - adjust IotProvider to use both of the above...
      - and then remove IotProvider's addition of JobMonitorProvider.  See commentary in IotProvider and EDGENT-397
    - some other general cleanup

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlaboss/incubator-edgent edgent112-cleanupJobMonitorApp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-edgent/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
    
----
commit c6f2ef1262336540980d51026e4b6759ff2463c7
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-03T22:35:23Z

    [WIP] [Edgent-112] Move or remove JobMonitorApp.submitApplication
    
    As noted in the JIRA there are other issues with the class as well.
    
    - migrate submitApplication() and closeJob() to new
    runtime.utils.TopologyMgmt
    - related, change ApplicationServiceMXBean.submit to return the created
    job's id
    - add JobMonitorApp.createAndRegister (the idiom used elsewhere)
    - adjust IotProvider to use both of the above
    - remove JobMonitorApp.submit() and adjust things
    - some other general cleanup

commit ead4f712c4d300f25e2e6e1a365edcc0f46dc032
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-04T02:15:19Z

    add gradle build parts, fix javadoc

commit 0a452bd5a63906adb879f894aa52aeaea283207c
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-14T14:28:29Z

    runtime.utils.TopologyMgmt => execution.utils.ExecutionMgmt

commit d8f1ffbdd5ee8964d5ef1f9972839f91a5413243
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-14T15:41:30Z

    take 2: execution.utils.ExecutionMgmt => utils.ExecutionMgmt
    
    execution.utils.ExecutionMgmt created a circular dependency created with
    topology

commit c5fe93651c1a49ce1905f6925902ed5f81c36b45
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-15T16:10:09Z

    Remove adding JobMonitorApp to IotProvider
    
    - do early detection of JobManagerApp usage requirements

commit 905965717962bbdf79efb013f468a07537121549
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2017-03-15T16:45:22Z

    minor cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---