You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/06/08 21:10:28 UTC
Review Request 35219: Relax requirement for .ini file sections.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35219/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1342
https://issues.apache.org/jira/browse/AURORA-1342
Repository: aurora
Description
-------
Relax requirement for .ini file sections.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 671b14fe4bcab933c2aaf3dff43ed6f9ef9c05fc
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java cb8b1add6b47a117b1f524759af2a35477a47561
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini 5303c6e5d969c85025b36319f6e3d84a7da31ce3
src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-no-sections.ini PRE-CREATION
Diff: https://reviews.apache.org/r/35219/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35219: Relax requirement for .ini file sections.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35219/#review87071
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On June 8, 2015, 7:10 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35219/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 7:10 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1342
> https://issues.apache.org/jira/browse/AURORA-1342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relax requirement for .ini file sections.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 671b14fe4bcab933c2aaf3dff43ed6f9ef9c05fc
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java cb8b1add6b47a117b1f524759af2a35477a47561
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini 5303c6e5d969c85025b36319f6e3d84a7da31ce3
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-no-sections.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35219/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35219: Relax requirement for .ini file sections.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35219/#review87069
-----------------------------------------------------------
Ship it!
Master (65739bb) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 8, 2015, 7:10 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35219/
> -----------------------------------------------------------
>
> (Updated June 8, 2015, 7:10 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1342
> https://issues.apache.org/jira/browse/AURORA-1342
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Relax requirement for .ini file sections.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java 671b14fe4bcab933c2aaf3dff43ed6f9ef9c05fc
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParserTest.java cb8b1add6b47a117b1f524759af2a35477a47561
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini 5303c6e5d969c85025b36319f6e3d84a7da31ce3
> src/test/resources/org/apache/aurora/scheduler/http/api/security/shiro-malformed-no-sections.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35219/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>