You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/07 05:33:54 UTC
[GitHub] [incubator-inlong] pocozh opened a new pull request #2964: [INLONG-2963][Manager] Fix get Pulsar url in CommonOperateService
pocozh opened a new pull request #2964:
URL: https://github.com/apache/incubator-inlong/pull/2964
### Title Name: [INLONG-2963][Manager]Fix get Pulsar url in CommonOperateService
Fixes #2963
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] pocozh commented on a change in pull request #2964: [INLONG-2963][Manager] Fix get Pulsar url in CommonOperateService
Posted by GitBox <gi...@apache.org>.
pocozh commented on a change in pull request #2964:
URL: https://github.com/apache/incubator-inlong/pull/2964#discussion_r820412427
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/CommonOperateService.java
##########
@@ -74,8 +74,12 @@ public String getSpecifiedParam(String key) {
case Constant.PULSAR_SERVICEURL: {
clusterEntity = getThirdPartyCluster(Constant.MIDDLEWARE_PULSAR);
if (clusterEntity != null) {
- params = gson.fromJson(clusterEntity.getExtParams(), Map.class);
- result = params.get(key);
+ if (key.equals(Constant.PULSAR_SERVICEURL)) {
Review comment:
okkk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #2964: [INLONG-2963][Manager] Fix get Pulsar url in CommonOperateService
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #2964:
URL: https://github.com/apache/incubator-inlong/pull/2964#discussion_r820396908
##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/CommonOperateService.java
##########
@@ -74,8 +74,12 @@ public String getSpecifiedParam(String key) {
case Constant.PULSAR_SERVICEURL: {
clusterEntity = getThirdPartyCluster(Constant.MIDDLEWARE_PULSAR);
if (clusterEntity != null) {
- params = gson.fromJson(clusterEntity.getExtParams(), Map.class);
- result = params.get(key);
+ if (key.equals(Constant.PULSAR_SERVICEURL)) {
Review comment:
In the `case` statement, you have already checked the key matches `Constant.PULSAR_SERVICEURL`, so it's recommended to remove this `if`, and do your work in `case Constant.PULSAR_ADMINURL` and `case Constant.PULSAR_SERVICEURL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #2964: [INLONG-2963][Manager] Fix get Pulsar url in CommonOperateService
Posted by GitBox <gi...@apache.org>.
healchow merged pull request #2964:
URL: https://github.com/apache/incubator-inlong/pull/2964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org