[GitHub] [solr] dsmiley commented on pull request #1313: SOLR-16629 Replace SolrSingleThreaded and SolrThreadSafe annotations with JCIP

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1313:
URL: https://github.com/apache/solr/pull/1313#issuecomment-1406079664

   Some of the edits to build.gradle was a bit of re-organization; all I _really_ did of substance is add one compileOnly to two files.  Maybe I should do such re-org separately; I would do even more organization.  I was trying to loosely order the dependencies.
   
   @risdenk I could use some assistance:
   ```
   * What went wrong:
   [24](https://github.com/apache/solr/actions/runs/4003404424/jobs/6871480844#step:7:25)
   Could not determine the dependencies of task ':solr:core:analyzeClassesDependencies'.
   [25](https://github.com/apache/solr/actions/runs/4003404424/jobs/6871480844#step:7:26)
   > Could not resolve all task dependencies for configuration ':solr:core:compileOnlyHelper'.
   [26](https://github.com/apache/solr/actions/runs/4003404424/jobs/6871480844#step:7:27)
      > Could not find com.github.stephenc.jcip:jcip-annotations:.
   [27](https://github.com/apache/solr/actions/runs/4003404424/jobs/6871480844#step:7:28)
        Required by:
   [28](https://github.com/apache/solr/actions/runs/4003404424/jobs/6871480844#step:7:29)
            project :solr:core
   ```
   
   I have some dissatisfaction with this dependency enforcement tool that you added.  I'm onboard with the best practice of declaring one's dependencies that are directly called but (a) the tool isn't smart enough -- we need to add permitUnusedDeclared and similar things, and (b) it doesn't understand the gradle concept of "api" in that it should be though of as inheriting a direct dependency rather than transitive.  So it's rather annoying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org