You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/06 16:05:01 UTC

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file

AndrewZhaoLuo commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1147617770

   If I understand this change correctly this is entirely style; git will handle different line deliminators fine, but the issue is that if a windows dev edits a file with LF, it will replace all lines with CRLF through the entire file which means every line will be changed in diffs. This will make the commit log a bit gummier.
   
   cc @areusch @driazati it seems like a good idea to force LF for new lines? can we lint for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org