You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/08/07 10:11:45 UTC
[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #295: fix snapshot check
pjfanning opened a new pull request, #295:
URL: https://github.com/apache/incubator-pekko-http/pull/295
problems with #294
* I added a stray `"` into the regex
* the Group match has to handle 3 extra subgroups that the regex change brings in
* for `1.1.0-M0+22-4f570ea2-SNAPSHOT`, the 3 extra subgroups are `-M0`, `-M`, `0`
* if there is no `-M0` (or `-RC0`), the extra subgroups are all null
* the sorting will do for now but it doesn't take into account whether the tag is M or RC and there are other problems
* I did play around with sbt.librarymanagement.VersionNumber but it doesn't have a comparator (or scala.Ordering implementation).
* I will try this again to see if I can create my own comparator for sbt.librarymanagement.VersionNumber
* using this PR to get the build working for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #295: fix snapshot check
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #295:
URL: https://github.com/apache/incubator-pekko-http/pull/295#issuecomment-1667597954
> I will try this again to see if I can create my own comparator for sbt.librarymanagement.VersionNumber
Having an ordering number for a `VersionNumber` doesn't make sense in a library like sbt because its completely bespoke, different orgs have the option of making their own release strategies.
In any case I would recommend how we approach this problem in general because there are issues in just using the latest snapshot as is done now, i.e. the builds are not deterministic which can be especially problematic if you are checking out past versions of pekko-http (i.e. trying to disect/figure out a bug) and instead of resolving the pekko version at that time you are instead resolving a completely different modern version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] pjfanning merged pull request #295: fix snapshot check
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #295:
URL: https://github.com/apache/incubator-pekko-http/pull/295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org