You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/20 02:50:33 UTC

[GitHub] [rocketmq] ltamber commented on a diff in pull request #4635: [ISSUE #4634] fix code style in namesrv module

ltamber commented on code in PR #4635:
URL: https://github.com/apache/rocketmq/pull/4635#discussion_r925114754


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java:
##########
@@ -88,51 +89,51 @@ public RemotingCommand processRequest(ChannelHandlerContext ctx,
 
         switch (request.getCode()) {
             case RequestCode.PUT_KV_CONFIG:
-                return this.putKVConfig(ctx, request);

Review Comment:
   IMO, It may be better to use a uniform signature for these methods, the contents here may be used later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org