You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Alex Deparvu (JIRA)" <ji...@apache.org> on 2018/11/05 08:57:00 UTC
[jira] [Commented] (OAK-7880) Reduce Principal lookup in default
access control code base
[ https://issues.apache.org/jira/browse/OAK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674834#comment-16674834 ]
Alex Deparvu commented on OAK-7880:
-----------------------------------
sure thing, a patch would be nice to see the proposed changes.
> Reduce Principal lookup in default access control code base
> -----------------------------------------------------------
>
> Key: OAK-7880
> URL: https://issues.apache.org/jira/browse/OAK-7880
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Attachments: AccessControlManagerImpl.java
>
>
> today i spotted to places in {{AccessControlManagerImpl}}, where i think the principal lookup could be omitted altogether:
> {{a) AccessControlManagerImpl.getPrincipal(Tree)}} : called when building policies from the content -> principal is always created even if not known.
> b) {{Util.checkValidPrincipal(Principal, PrincipalManager, int)}} : in case of ImportBehavior.BESTEFFORT the result of the lookup is ignored and the lookup could in this case be omitted.
> [~stillalex], what do you think? If you feel this is worth addressing, I would create a patch.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)