You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Greg Stein (JIRA)" <ji...@apache.org> on 2009/01/30 14:11:59 UTC
[jira] Created: (THRIFT-292) contrib/fb303 needs removal or cleanup
contrib/fb303 needs removal or cleanup
--------------------------------------
Key: THRIFT-292
URL: https://issues.apache.org/jira/browse/THRIFT-292
Project: Thrift
Issue Type: Bug
Reporter: Greg Stein
Fix For: 0.1
The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-292) contrib/fb303 needs removal or cleanup
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-292:
-------------------------------
Attachment: 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch
0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch
0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch
0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch
0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch
0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Steve Corona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670935#action_12670935 ]
Steve Corona commented on THRIFT-292:
-------------------------------------
FYI- In order to get fb303 to compile from the trunk, I had to comment out #include "thrift/if/reflection_limited.thrift" from fb303.thrift and s/facebook/apache/g in the cpp folder.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668916#action_12668916 ]
Michael Greene commented on THRIFT-292:
---------------------------------------
Could you please describe the ways in which it needs to be updated to match Apache guidelines?
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670228#action_12670228 ]
Michael Greene commented on THRIFT-292:
---------------------------------------
Judging by the way other Apache projects are using those terms, e.g.
http://svn.apache.org/repos/asf/hadoop/core/trunk/src/contrib/
http://svn.apache.org/repos/asf/tapestry/tapestry4/trunk/tapestry-contrib/
http://svn.apache.org/repos/asf/incubator/ivy/core/trunk/src/example/
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/examples/
http://svn.apache.org/repos/asf/tapestry/tapestry4/trunk/tapestry-examples/
It looks like the connotation behind "contrib" is a contributed project that can be incorporated into your own projects, built on top of the base Apache project -- whereas the connotation behind "example" is something to get you started using the base Apache project, but intended as a learning device more than to be incorporated in its entirety.
I think fb303 fits the the first description better, but I may be reading contrib/example wrong.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670227#action_12670227 ]
Jeff Hammerbacher commented on THRIFT-292:
------------------------------------------
Hey Greg,
The Hadoop project uses the contrib/ folder pretty successfully, and fb303 seems to be in a similar spirit to some of the Hadoop contrib projects. I'm happy with the status quo, especially because fb303 is less of an example and more of a core component to other Thrift services.
Later,
Jeff
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Anthony Giardullo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670675#action_12670675 ]
Anthony Giardullo commented on THRIFT-292:
------------------------------------------
Looks good. Thanks!
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683770#action_12683770 ]
David Reiss commented on THRIFT-292:
------------------------------------
I committed all of mine. I'm not sure what other "clean up" people think is necessary.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668923#action_12668923 ]
Greg Stein commented on THRIFT-292:
-----------------------------------
I'm thinking of the IP stuff. Primarily, updating the headers with the appropriate licensing information.
In essence, if the ASF distributes it, then it needs to *be* Apache code. The idea of "contrib" doesn't really make sense as a result, so this code would be more like an "example" or a working tutorial or something.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670226#action_12670226 ]
Greg Stein commented on THRIFT-292:
-----------------------------------
Yup. Fair enough.
I'd also like input on swiching this from a "contrib" concept to an "example". Particularly cuz of issues around "what does contrib really mean, if Apache stands behind everything it distributes?"
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-292) contrib/fb303 needs removal or cleanup
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Stein updated THRIFT-292:
------------------------------
Priority: Blocker (was: Major)
Changing to Blocker. Cannot release or graduate without fixing this.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683720#action_12683720 ]
Bryan Duxbury commented on THRIFT-292:
--------------------------------------
What's the status on this issue? Can we apply the patches and close?
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12693839#action_12693839 ]
Bryan Duxbury commented on THRIFT-292:
--------------------------------------
If we don't hear from Greg by end of day today, I'm closing this issue.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Greg Stein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668985#action_12668985 ]
Greg Stein commented on THRIFT-292:
-----------------------------------
Some of the generated artifacts have been removed in r739384. I'm not entirely sure that I got them all -- wanted to be safe.
Leaving this open since I have not worked on the headers.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670647#action_12670647 ]
David Reiss commented on THRIFT-292:
------------------------------------
Hey Anthony. I needed to apply all of these changes to get fb303 to build and install cleanly and to get scribe to build. Are you okay if we check these in?
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Anthony Giardullo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670203#action_12670203 ]
Anthony Giardullo commented on THRIFT-292:
------------------------------------------
I agree that it is much cleaner to remove this generated code. However, the Makefiles now need to be changed in order to generate this code. Currently, fb303 does not build (it will complain that 'py/fb303' is not found). Even if I configure fb303 to generate the python code(ie --with-py), it will get generated in a different directory than the makefile expects.
fb303 is a dependency for Scribe (https://sourceforge.net/projects/scribeserver/), so I would appreciate it if we can fix fb303 so that it builds successfully.
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-292) contrib/fb303 needs removal or cleanup
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-292.
--------------------------------
Resolution: Fixed
Assignee: David Reiss
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Assignee: David Reiss
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-292) contrib/fb303 needs removal or
cleanup
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683927#action_12683927 ]
Bryan Duxbury commented on THRIFT-292:
--------------------------------------
Can Greg weigh in on whether this issue is resolved then?
> contrib/fb303 needs removal or cleanup
> --------------------------------------
>
> Key: THRIFT-292
> URL: https://issues.apache.org/jira/browse/THRIFT-292
> Project: Thrift
> Issue Type: Bug
> Reporter: Greg Stein
> Priority: Blocker
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-292.-Restore-fb303-FacebookBase.py.patch, 0002-THRIFT-292.-Make-the-includes-in-fb303-match-the-re.patch, 0003-THRIFT-292.-s-facebook-thrift-apache-thrift-in-co.patch, 0004-THRIFT-292.-Delete-aclocal.m4-a-generated-file.patch, 0005-THRIFT-292.-Auto-generate-the-Java-gen-code-in-build.patch, 0006-THRIFT-292.-Auto-generate-the-Python-gen-code-in-bui.patch, 0007-THRIFT-292.-Install-fb303.thrift-in-a-more-sensible.patch
>
>
> The contrib/fb303 needs to be removed, or it needs to be updated to match Apache guidelines.
> In addition, there are generated artifacts which should be removed from source control. At least: fb303/py/, fb303/php/, and fb303/java/.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.