You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/02/20 02:02:17 UTC

[GitHub] [beam] lostluck commented on pull request #25557: [prism] Add testdofns for later

lostluck commented on PR #25557:
URL: https://github.com/apache/beam/pull/25557#issuecomment-1436193423

   R: @johannaojeling 
   
   This one is what it says on the tin. A bunch of Test DoFns that will eventually migrate into just the test file itself, instead of living in the package. 
   
   Having them in the "production" part of the package simplifies getting coverage numbers while iterating, and ensuring the different methods on the DoFns are activated as expected. Once metrics support in the runner is sufficiently robust, that can be changed to using counters and similar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org