[GitHub] [shardingsphere-elasticjob] TeslaCN commented on a diff in pull request #2211: add zk listener remove to avoid memory leak.

["TeslaCN (via GitHub)" <gi...@apache.org>]

TeslaCN commented on code in PR #2211:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2211#discussion_r1169685343


##########
elasticjob-infra/elasticjob-registry-center/elasticjob-regitry-center-provider/elasticjob-registry-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/elasticjob/reg/zookeeper/ZookeeperRegistryCenter.java:
##########
@@ -71,7 +74,19 @@ public final class ZookeeperRegistryCenter implements CoordinatorRegistryCenter
     private final ZookeeperConfiguration zkConfig;
     
     private final Map<String, CuratorCache> caches = new ConcurrentHashMap<>();
-    
+
+    /**
+     * Data listener list.
+     */
+    @Getter(AccessLevel.PROTECTED)

Review Comment:
   It seems that the Getter is used by test code only. Could we consider removing this and get field by Mockito Plugins or reflection in test code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org