You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/02/27 00:03:26 UTC
[GitHub] [druid] samarthjain opened a new pull request #9422: Handle unknown
complex types
samarthjain opened a new pull request #9422: Handle unknown complex types
URL: https://github.com/apache/druid/pull/9422
Fixes #9421
This PR has:
- [X ] been self-reviewed.
- [X ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ X] added documentation for new or modified features or behaviors.
- [ X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [X ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X ] been tested in a test Druid cluster.
##### Key changed/added classes in this PR
* UnknownTypeComplexColumn.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] samarthjain commented on issue #9422: Handle unknown
complex types
Posted by GitBox <gi...@apache.org>.
samarthjain commented on issue #9422: Handle unknown complex types
URL: https://github.com/apache/druid/pull/9422#issuecomment-591853920
@gianm - appreciate if you can take a look. I tested it out on our cluster and I see the DruidSchema cache is working fine again since the SegmentMetadata queries are no longer failing with NPE when encountering unknown aggregators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] samarthjain commented on issue #9422: Handle unknown
complex types
Posted by GitBox <gi...@apache.org>.
samarthjain commented on issue #9422: Handle unknown complex types
URL: https://github.com/apache/druid/pull/9422#issuecomment-592259856
Pushed a commit to add test that breaks without this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] samarthjain opened a new pull request #9422: Handle unknown
complex types
Posted by GitBox <gi...@apache.org>.
samarthjain opened a new pull request #9422: Handle unknown complex types
URL: https://github.com/apache/druid/pull/9422
Fixes #9421
This PR has:
- [X ] been self-reviewed.
- [X ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ X] added documentation for new or modified features or behaviors.
- [ X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [X ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [X ] been tested in a test Druid cluster.
##### Key changed/added classes in this PR
* UnknownTypeComplexColumn.java
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] samarthjain closed pull request #9422: Handle unknown
complex types
Posted by GitBox <gi...@apache.org>.
samarthjain closed pull request #9422: Handle unknown complex types
URL: https://github.com/apache/druid/pull/9422
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org