You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/11/08 19:03:17 UTC
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/416
DISPATCH-1176 - Do not continue processing settled streaming deliveri…
…es when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit f3d2de1b747b4d60210f72ee7b9da93db3c151e3
Author: Ganesh Murthy <gm...@...>
Date: 2018-11-08T18:34:38Z
DISPATCH-1176 - Do not continue processing settled streaming deliveries when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/416#discussion_r232051930
--- Diff: src/router_core/transfer.c ---
@@ -1252,6 +1252,14 @@ static void qdr_deliver_continue_CT(qdr_core_t *core, qdr_action_t *action, bool
// This is a multicast delivery or if this is a presettled multi-frame unicast delivery.
if (in_dlv->multicast || in_dlv->settled) {
+
+ //
+ // If a delivery is settled but did not go into one of the lists, that means that it is going nowhere.
+ // We dont want to deal with such deliveries.
+ //
+ if (in_dlv->settled && in_dlv->where == QDR_DELIVERY_NOWHERE)
--- End diff --
Can a test be written that exercises this case?
Did you verify that the delivery being processed has not been freed?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/416
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/416
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #416: DISPATCH-1176 - Do not continue processing ...
Posted by ganeshmurthy <gi...@git.apache.org>.
GitHub user ganeshmurthy reopened a pull request:
https://github.com/apache/qpid-dispatch/pull/416
DISPATCH-1176 - Do not continue processing settled streaming deliveri…
…es when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit f3d2de1b747b4d60210f72ee7b9da93db3c151e3
Author: Ganesh Murthy <gm...@...>
Date: 2018-11-08T18:34:38Z
DISPATCH-1176 - Do not continue processing settled streaming deliveries when they have nowhere to go. If the settled delivery is not in any of the lists, dont process it
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org