You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/04/15 02:11:38 UTC
[GitHub] [systemds] j143 opened a new pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
j143 opened a new pull request #1225:
URL: https://github.com/apache/systemds/pull/1225
* `mvn clean package -P distribution`
also builds and outputs the python artifacts in the
top level target folder
Closes #1225.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-846713186
Hi @phaniarnab,
1. We could use this goal for python build while issuing `mvn deploy -P 'distribution'`.
2. We could disable this during the regular development testing, though. as Sebastian suggested above.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 closed pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
j143 closed pull request #1225:
URL: https://github.com/apache/systemds/pull/1225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-820204693
Hi @j143
I both like and dislike the idea.
on one hand it makes sense to have a one place build all, but I'm worried about 2 things.
1. Increased package time... (i package the project 10 - 100 times a day) so if it increase this i would not have this change
2. Confusion about what is inside our builds, since with this we have to manage the python API in our build of the system, rather than only in connection with python.
If you really really like the feature, and intend to use it. I would make it execute under a specific -D like PythonAPI, but then again it does not hook up into anything so there is more work needed if we want to pursue this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-847115012
As per mailing list discussion,
We will build python independent of maven! ✨
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-819997423
cc @Baunsgaard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] phaniarnab commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
phaniarnab commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-846870739
I agree with @Baunsgaard, especially the second point.
For deployment, which we do only during releases, I can't think of a strong reason to make it a part of the pom.
Other than that, we need to meticulously check the builds, what it contains, and the package's size if you use this proposed option. Not sure if we want to upload python packages in the Apache distribution repository and open them for voting too during releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] j143 commented on pull request #1225: [SYSTEMDS-2916] Build python dist with maven package
Posted by GitBox <gi...@apache.org>.
j143 commented on pull request #1225:
URL: https://github.com/apache/systemds/pull/1225#issuecomment-847042903
In SystemML, we released python artifacts along with java ones. Here - https://dist.apache.org/repos/dist/dev/systemds/1.1.0-rc1/
after offline discussion with Arnab,
It will be a good idea to keep the python package for voting. And we could pursue this one. Also, at the moment let us hold this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org