[jira] [Commented] (WICKET-6434) Fixed WicketTester to detect components in enclosure when doing isComponentOnAjaxResponse.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112589#comment-16112589 ] 

ASF GitHub Bot commented on WICKET-6434:
----------------------------------------

Github user klopfdreh commented on the issue:

    https://github.com/apache/wicket/pull/224
  
    Thanks a lot for your effort. @martin-g I saw you did the review already. I created a JIRA ticket: https://issues.apache.org/jira/browse/WICKET-6434.


> Fixed WicketTester to detect components in enclosure when doing isComponentOnAjaxResponse.
> ------------------------------------------------------------------------------------------
>
>                 Key: WICKET-6434
>                 URL: https://issues.apache.org/jira/browse/WICKET-6434
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0-M6
>            Reporter: Tobias Soloschenko
>            Assignee: Martin Grigorov
>            Priority: Minor
>              Labels: fix
>             Fix For: 8.0.0-M7
>
>
> When a component is in a wicket:enclosure and is then correctly re-rendered using ajax, WicketTester seemed to not be able to detect that the component was in the ajax response in the isComponentOnAjaxResponse method.
> A functionality has been additionalwhere isComponentOnAjaxResponse tries to find an enclosure whose child is the given component, and if one is found, it recurses into isComponentOnAjaxResponse passing the enclosure as an argument.
> In order not to duplicate logic detecting when an enclosure's child is a given component, AjaxEnclosureListener's isControllerOfEnclosure has been switched to public and static.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)