You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Robert Burke (Jira)" <ji...@apache.org> on 2022/01/25 04:54:00 UTC
[jira] [Created] (BEAM-13736) [Go SDK] Fix hash collision risk in Combiner Lifting cache
Robert Burke created BEAM-13736:
-----------------------------------
Summary: [Go SDK] Fix hash collision risk in Combiner Lifting cache
Key: BEAM-13736
URL: https://issues.apache.org/jira/browse/BEAM-13736
Project: Beam
Issue Type: Improvement
Components: sdk-go
Reporter: Robert Burke
Relying only on a hash is brittle for map implementations, and can lead to correctness issues when keys collide.
While the Go SDK implementation is leaning on the Go map, we need to rely on byte equality so we need to fend for ourselves a bit, and handle overflow buckets and the like.
We won't go so far as to do a rehash or similar balancing techniques as it's not clear that between the caches' size constraint, and the evenness of the hash function that they are all that likely.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)