You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2020/09/09 02:45:39 UTC

Review Request 72846: Corrected the example of the managed CSI plugin.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72846/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10151
    https://issues.apache.org/jira/browse/MESOS-10151


Repository: mesos


Description
-------

Corrected the example of the managed CSI plugin.


Diffs
-----

  docs/configuration/agent.md 4899202e1afa2988acb3c066829e26aa9612fd29 
  src/slave/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3 


Diff: https://reviews.apache.org/r/72846/diff/1/


Testing
-------


Thanks,

Qian Zhang


Re: Review Request 72846: Corrected the example of the managed CSI plugin.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72846/#review221833
-----------------------------------------------------------



Patch looks great!

Reviews applied: [72846]

Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

- Mesos Reviewbot


On Sept. 9, 2020, 2:46 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72846/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2020, 2:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10151
>     https://issues.apache.org/jira/browse/MESOS-10151
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Corrected the example of the managed CSI plugin.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 4899202e1afa2988acb3c066829e26aa9612fd29 
>   src/slave/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3 
> 
> 
> Diff: https://reviews.apache.org/r/72846/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 72846: Corrected the example of the managed CSI plugin.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72846/#review221980
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Sept. 9, 2020, 2:46 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72846/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2020, 2:46 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10151
>     https://issues.apache.org/jira/browse/MESOS-10151
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Corrected the example of the managed CSI plugin.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 4899202e1afa2988acb3c066829e26aa9612fd29 
>   src/slave/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3 
> 
> 
> Diff: https://reviews.apache.org/r/72846/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 72846: Corrected the example of the managed CSI plugin.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72846/
-----------------------------------------------------------

(Updated Sept. 9, 2020, 10:46 a.m.)


Review request for mesos, Andrei Budnik and Greg Mann.


Bugs: MESOS-10151
    https://issues.apache.org/jira/browse/MESOS-10151


Repository: mesos


Description
-------

Corrected the example of the managed CSI plugin.


Diffs
-----

  docs/configuration/agent.md 4899202e1afa2988acb3c066829e26aa9612fd29 
  src/slave/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3 


Diff: https://reviews.apache.org/r/72846/diff/1/


Testing
-------


Thanks,

Qian Zhang