You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "photino (via GitHub)" <gi...@apache.org> on 2024/12/05 07:43:54 UTC
[I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
photino opened a new issue, #5391:
URL: https://github.com/apache/opendal/issues/5391
### Describe the bug
We am using the `OSS` service. When deleting a path contains chinese characters, it throws an error:
```
Unexpected (permanent) at List::next, context: { called: reqsign::Sign, service: oss, path: 中文目录/, listed: 0 } => signing http request, source: invalid uri character
```
### Steps to Reproduce
```rust
let mut builder = Oss::default()
.root("/path/to/dir")
.bucket("test")
.endpoint("https://oss-cn-beijing.aliyuncs.com")
.access_key_id("access_key_id")
.access_key_secret("access_key_secret");;
let op: Operator = Operator::new(builder)?.finish();
operator.remove_all("中文目录/").unwrap();
```
### Expected Behavior
Should work successfully.
### Additional Context
OpenDAL version: `0.50.2`
### Are you willing to submit a PR to fix this bug?
- [ ] Yes, I would like to submit a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2788557974
reqsign 0.16.2 should fix your issues, thanks a lot for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2788276366
> Does the `remove_all` call on `list`?
Yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2788333654
OK. I have submited another PR to 0.16.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2747478421
Hi, @photino, thanks a lot for contribution! I will take a look this week.
The things we need:
- [ ] Merge this patch in main
- [ ] Backport to 0.16.x branch
- [ ] Make a new release for 0.17.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2644539770
Oh, sorry for not finding time to fix this. Would you like to fix it yourself?
We need to implement the same logic here:
https://github.com/Xuanwo/reqsign/blob/13c22a1b0a2609862c1dcb9b42647cf5b270fd31/src/aws/v4.rs#L350-L359
in
https://github.com/Xuanwo/reqsign/blob/13c22a1b0a2609862c1dcb9b42647cf5b270fd31/src/aliyun/oss.rs#L188C4-L188C25
Would you be willing to implement this in the `main` branch of reqsign and backport it to the 0.16.x branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2644528137
Any progress on fixing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2644747066
I don't understand why the path `"中文目录/"` is related to `ctx.query()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2519610750
Thank you, @photino, for reporting the bug. I have confirmed that it is indeed an issue caused by reqsign, where the query is not encoded correctly like s3.
https://github.com/Xuanwo/reqsign/blob/13c22a1b0a2609862c1dcb9b42647cf5b270fd31/src/aws/v4.rs#L347-L360
I will get it fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #5391: bug: Invalid uri character when the URL path contains chinese characters
URL: https://github.com/apache/opendal/issues/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2786000073
Does the `remove_all` call on `list`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2785321336
After upgrading to 0.54.0, tt seems that we can delete a path contains chinese characters successfully.
Is the bug fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2650968767
> I don't understand why the path `"/dev/foo/中文目录/"` is related to `ctx.query`.
This is `ListObjects` request, so the path `/dev/foo/中文目录/` is instead query `prefix=/dev/foo/中文目录/` instead of path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "photino (via GitHub)" <gi...@apache.org>.
photino commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2747364671
I have added the percent encoding in https://github.com/Xuanwo/reqsign/pull/507
Do we need a new release of reqsign to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #5391: bug: Invalid uri character when the URL path contains chinese characters
URL: https://github.com/apache/opendal/issues/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #5391: bug: Invalid uri character when the URL path contains chinese characters
URL: https://github.com/apache/opendal/issues/5391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] bug: Invalid uri character when the URL path contains chinese characters [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #5391:
URL: https://github.com/apache/opendal/issues/5391#issuecomment-2785968364
> After upgrading to 0.53.0, it seems that we can delete a path contains chinese characters successfully.
>
> Is the bug fixed?
The issue happens in `list`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org