You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2021/10/04 21:26:42 UTC
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
From Michael Blow <mb...@apache.org>:
Hello Dmitry Lychagin, Till Westmann, Jenkins, Anon. E. Moose #1000171, Till Westmann,
I'd like you to do a code review. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
to review the following change.
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Revert "[NO ISSUE] Import JDBC driver"
This reverts commit 4a90403744f1b9bbd16e40fda6a8a60101ea4069.
Reason for revert: incorrectly submitted
Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
---
D asterix-jdbc-core/NOTICE
D asterix-jdbc-core/pom.xml
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBColumn.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBConnection.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatabaseMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatatype.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverBase.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverContext.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverProperty.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBErrorReporter.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBMetaStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBParameterMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBPreparedStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProductVersion.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProtocol.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSet.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSetMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBRowStore.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBWrapperSupport.java
D asterix-jdbc-driver/NOTICE
D asterix-jdbc-driver/pom.xml
D asterix-jdbc-driver/src/main/java/org/apache/asterix/jdbc/Driver.java
D asterix-jdbc-driver/src/main/resources/META-INF/services/java.sql.Driver
24 files changed, 0 insertions(+), 8,197 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/13523/1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Ian Maxon <im...@uci.edu>:
Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523 )
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 21:29:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Hello Dmitry Lychagin, Till Westmann, Jenkins, Anon. E. Moose #1000171, Till Westmann,
I'd like you to do a code review. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
to review the following change.
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Revert "[NO ISSUE] Import JDBC driver"
This reverts commit 4a90403744f1b9bbd16e40fda6a8a60101ea4069.
Reason for revert: incorrectly submitted
Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
---
D asterix-jdbc-core/NOTICE
D asterix-jdbc-core/pom.xml
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBColumn.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBConnection.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatabaseMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatatype.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverBase.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverContext.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverProperty.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBErrorReporter.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBMetaStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBParameterMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBPreparedStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProductVersion.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProtocol.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSet.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSetMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBRowStore.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBWrapperSupport.java
D asterix-jdbc-driver/NOTICE
D asterix-jdbc-driver/pom.xml
D asterix-jdbc-driver/src/main/java/org/apache/asterix/jdbc/Driver.java
D asterix-jdbc-driver/src/main/resources/META-INF/services/java.sql.Driver
24 files changed, 0 insertions(+), 8,197 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/13523/1
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-MessageType: newchange
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
Anon. E. Moose #1000171 has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523 )
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Patch Set 1: Contrib-2
Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/sVQB9Vcn8wzUqsLW6 : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 21:33:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has submitted this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523 )
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Revert "[NO ISSUE] Import JDBC driver"
This reverts commit 4a90403744f1b9bbd16e40fda6a8a60101ea4069.
Reason for revert: inadvertently submitted
Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
Reviewed-by: Ian Maxon <im...@uci.edu>
Tested-by: Michael Blow <mb...@apache.org>
---
D asterix-jdbc-core/NOTICE
D asterix-jdbc-core/pom.xml
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBColumn.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBConnection.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatabaseMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDatatype.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverBase.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverContext.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBDriverProperty.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBErrorReporter.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBMetaStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBParameterMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBPreparedStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProductVersion.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBProtocol.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSet.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBResultSetMetaData.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBRowStore.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBStatement.java
D asterix-jdbc-core/src/main/java/org/apache/asterix/jdbc/core/ADBWrapperSupport.java
D asterix-jdbc-driver/NOTICE
D asterix-jdbc-driver/pom.xml
D asterix-jdbc-driver/src/main/java/org/apache/asterix/jdbc/Driver.java
D asterix-jdbc-driver/src/main/resources/META-INF/services/java.sql.Driver
24 files changed, 0 insertions(+), 8,197 deletions(-)
Approvals:
Ian Maxon: Looks good to me, approved
Michael Blow: Verified
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-MessageType: merged
Change in asterixdb[master]: Revert "[NO ISSUE] Import JDBC driver"
Posted by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu>.
From Michael Blow <mb...@apache.org>:
Michael Blow has removed a vote from this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523 )
Change subject: Revert "[NO ISSUE] Import JDBC driver"
......................................................................
Removed Contrib-2 by Anon. E. Moose (1000171)
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/13523
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Ia34f640d837e97405e6ee0530f8cd68a2610cd65
Gerrit-Change-Number: 13523
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@couchbase.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-CC: Till Westmann <ti...@gmail.com>
Gerrit-MessageType: deleteVote