[GitHub] [spark] maropu commented on a change in pull request #30303: [SPARK-33404][SQL] Fix incorrect results in `date_trunc` expression

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30303:
URL: https://github.com/apache/spark/pull/30303#discussion_r520194695



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -571,14 +571,19 @@ class DateTimeUtilsSuite extends SparkFunSuite with Matchers with SQLHelper {
         val inputTS4 = DateTimeUtils.stringToTimestamp(
           UTF8String.fromString("2015-03-29T02:32:05.359"), defaultZoneId)
         val inputTS5 = DateTimeUtils.stringToTimestamp(
-          UTF8String.fromString("1999-03-29T01:02:03.456789"), defaultZoneId)
+          UTF8String.fromString("1769-10-17 17:10:02.123456"), defaultZoneId)

Review comment:
       Could you add a new test unit like `test("SPARK-33404: XXXX") { ...} ` instead of modifying the existing test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org