You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/09/08 04:04:41 UTC
[GitHub] [ozone] Xushaohong opened a new pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Xushaohong opened a new pull request #2622:
URL: https://github.com/apache/ozone/pull/2622
## What changes were proposed in this pull request?
Add RaftpeerId for the shell command " ozone admin scm roles"
In the current scm log files, some of the raft related logs lack explicit Addresses, so it is hard to distinguish the SCM nodes from the abstract UUID. We can add the RaftPeerId into the command -> ozone admin scm roles, which can help find the SCM node mentioned in logs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5724
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915066919
@ChenSammi , Pls take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also?
@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId.
I am wondering the followings:
1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
2. after that we could unify the pattern the getting om/scm roles return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915990905
Thank You @Xushaohong for the contribution and @JacksonYao287 for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also?
@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId.
I am wandering the followings:
1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
2. after that we could unify the pattern the getting om/scm roles return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also?
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId, i am wandering the followings:
1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
2. after that we could unify the pattern the getting om/scm roles return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2622:
URL: https://github.com/apache/ozone/pull/2622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 commented on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915990255
> > LGTM, can we do similar change for OM also?
>
> @bharatviswa504
> OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
> Right now the OM side will print NodeId.
>
> I am wondering the followings:
>
> 1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
> 2. after that we could unify the pattern the getting om/scm roles return
You are right, I missed that we use node id as raft peer id in OM, and which is now already shown..
Lets not go the route of peerID unification, as if we want to do we need to consider fresh/old installation.
Where in fresh installations we can generate UUIDS, and old we should we should have as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also?
@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId, i am wandering the followings:
1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
2. after that we could unify the pattern the getting om/scm roles return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bharatviswa504 merged pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #2622:
URL: https://github.com/apache/ozone/pull/2622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-915809805
> LGTM, can we do similar change for OM also?
@bharatviswa504
OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
Right now the OM side will print NodeId.
I am wandering the followings:
1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
2. after that we could unify the pattern the getting om/scm roles return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-916020754
> > > LGTM, can we do similar change for OM also?
> >
> >
> > @bharatviswa504
> > OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
> > Right now the OM side will print NodeId.
> > I am wondering the followings:
> >
> > 1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
> > 2. after that we could unify the pattern the getting om/scm roles return
>
> You are right, I missed that we use node id as raft peer id in OM, and which is now already shown..
>
> Lets not go the route of peerID unification, as if we want to do we need to consider fresh/old installation.
>
> Where in fresh installations we can generate UUIDS, and old we should we should have as it is.
Do you mean that the unification needs some concern about compatibility? Because someone may have already set up the cluster.
Actually what I concern about is what if om nodes vary, such as from ABC to ABD, the corresponding log only shows abstract node name instead of specific UUID pointing to the specific node. This is the disadvantage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong edited a comment on pull request #2622: HDDS-5724. Add RaftpeerId when getting scm roles
Posted by GitBox <gi...@apache.org>.
Xushaohong edited a comment on pull request #2622:
URL: https://github.com/apache/ozone/pull/2622#issuecomment-916020754
> > > LGTM, can we do similar change for OM also?
> >
> >
> > @bharatviswa504
> > OM uses OmNodeId as RaftPeerID, such as "om1" "om2" "om3 ", while SCM use scmUUID as RaftPeerID, and thus the log trace could be confusing for finding the right SCM node.
> > Right now the OM side will print NodeId.
> > I am wondering the followings:
> >
> > 1. should we unifiy the RaftPeerId usage for OM and SCM ? (obviously UUID is better for indicating the physical node)
> > 2. after that we could unify the pattern the getting om/scm roles return
>
> You are right, I missed that we use node id as raft peer id in OM, and which is now already shown..
>
> Lets not go the route of peerID unification, as if we want to do we need to consider fresh/old installation.
>
> Where in fresh installations we can generate UUIDS, and old we should we should have as it is.
Do you mean that the unification needs some concern about compatibility? Because someone may have already set up the cluster.
Actually what I concern about is what if om nodes vary, such as from ABC to ABD, the corresponding log only shows abstract node name instead of specific UUID pointing to the specific node. Losing the context could be a disadvantage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org