You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by qiuchenjian <gi...@git.apache.org> on 2018/02/02 16:18:43 UTC

[GitHub] carbondata pull request #1916: [CARBONDATA-2110]deprecate 'tempCSV' option o...

GitHub user qiuchenjian opened a pull request:

    https://github.com/apache/carbondata/pull/1916

    [CARBONDATA-2110]deprecate 'tempCSV' option of dataframe load

    deprecate 'tempCSV' option of dataframe load, it won't generate temp file on hdfs,  no matter the value of tempCSV
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qiuchenjian/carbondata master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/1916.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1916
    
----
commit f30fea0d02b35878017e514b5124c2943c7d6b49
Author: qiuchenjian <80...@...>
Date:   2018-02-02T16:14:07Z

    deprecate 'tempCSV' option of dataframe load, it won't generate temp file on hdfs,  no matter the value of tempCSV

----


---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3321/



---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    Can you search for tempCSV in all testcases and delete them, I think you can do it easily in IDE 


---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    I think the tests with tempCSV need be kept, because the customer is still using the option @jackylk 


---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2212/



---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by qiuchenjian <gi...@git.apache.org>.
Github user qiuchenjian commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    @jackylk ,fix bugs as mentioned


---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3452/



---

[GitHub] carbondata issue #1916: [CARBONDATA-2110]deprecate 'tempCSV' option of dataf...

Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/1916
  
    LGTM


---

[GitHub] carbondata pull request #1916: [CARBONDATA-2110]deprecate 'tempCSV' option o...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/1916


---