You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/18 12:48:51 UTC

[GitHub] [ratis] adoroszlai opened a new pull request, #719: RATIS-1680. TestLeaderInstallSnapshot creates untracked files

adoroszlai opened a new pull request, #719:
URL: https://github.com/apache/ratis/pull/719

   ## What changes were proposed in this pull request?
   
   `TestLeaderInstallSnapshot` leaves untracked files in `ratis-test/snapshot` directory.
   
   ```
   $ mvn clean test -DfailIfNoTests=false -Dtest=TestLeaderInstallSnapshot
   ...
   $ git status
   On branch master
   Your branch is up to date with 'origin/master'.
   
   Untracked files:
     (use "git add <file>..." to include in what will be committed)
   
   	ratis-test/snapshot/
   
   nothing added to commit but untracked files present (use "git add" to track)
   
   $ find ratis-test/snapshot | sort
   ratis-test/snapshot
   ratis-test/snapshot/1.bin
   ratis-test/snapshot/sub
   ratis-test/snapshot/sub/2.bin
   ```
   
   The root cause is that `getSMdir()` returns `null` until storage is initialized.
   
   https://issues.apache.org/jira/browse/RATIS-1680
   
   ## How was this patch tested?
   
   ```
   $ mvn clean test -DfailIfNoTests=false -Dtest=TestLeaderInstallSnapshot
   ...
   $ git status
   On branch RATIS-1680
   
   nothing to commit, working tree clean
   ```
   
   Regular CI:
   https://github.com/adoroszlai/incubator-ratis/actions/runs/2882163120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] adoroszlai commented on pull request #719: RATIS-1680. TestLeaderInstallSnapshot creates untracked files

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #719:
URL: https://github.com/apache/ratis/pull/719#issuecomment-1219758128

   Thanks @szetszwo for reviewing and committing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #719: RATIS-1680. TestLeaderInstallSnapshot creates untracked files

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #719:
URL: https://github.com/apache/ratis/pull/719


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org