[jira] [Commented] (WICKET-5845) AuthenticatedWebSession.get() returns a new session with signedIn false

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384589#comment-14384589 ] 

ASF subversion and git services commented on WICKET-5845:
---------------------------------------------------------

Commit 972746aa01094db5ca6a0ea6aafe6528451eef03 in wicket's branch refs/heads/master from [~mgrigorov]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=972746a ]

WICKET-5845 AuthenticatedWebSession.get() returns a new session with signedIn false

Revert WICKET-5775. It has broken several scenaria


> AuthenticatedWebSession.get() returns a new session with signedIn false
> -----------------------------------------------------------------------
>
>                 Key: WICKET-5845
>                 URL: https://issues.apache.org/jira/browse/WICKET-5845
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-auth-roles
>    Affects Versions: 7.0.0-M5, 6.19.0
>         Environment: java version "1.7.0_75", Windows 7
>            Reporter: Jirka
>
> A change from Wicket 6.18.0 to Wicket 6.19.0 causes that after a successful authentication {{AuthenticatedWebSession.get()}} returns a new session with the {{signedIn}} variable set to {{false}} although during the authentication the original session sets {{signedIn}} to {{true}}. 
> Wicket 6.18.0
> {{org.apache.wicket.authroles.authentication.AuthenticatedWebSession}}
> {code}
> public final boolean signIn(final String username, final String password)
> 	{
> 		signedIn = authenticate(username, password);
> 		if (signedIn)
> 		{
> 			bind();
> 		}
> 		return signedIn;
> 	}
> {code}
> Wickey 6.19.0
> {code}
> public final boolean signIn(final String username, final String password)
> 	{
> 		signedIn = authenticate(username, password);
> 		if (signedIn)
> 		{
> 			replaceSession();
> 		}
> 		return signedIn;
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)