[jira] [Created] (HBASE-19249) test for "hbase antipatterns" should check _count_ of occurance rather than text of

["Sean Busbey (JIRA)" <ji...@apache.org>]

Sean Busbey created HBASE-19249:
-----------------------------------

             Summary: test for "hbase antipatterns" should check _count_ of occurance rather than text of
                 Key: HBASE-19249
                 URL: https://issues.apache.org/jira/browse/HBASE-19249
             Project: HBase
          Issue Type: Bug
          Components: build
            Reporter: Sean Busbey
            Assignee: Sean Busbey
            Priority: Critical


[~appy] noticed on HBASE-18624 that our check for Hadoop annotations failed to flag a use.

looking at our check:

{code}

  warnings=$(${GREP} 'import org.apache.hadoop.classification' "${patchfile}")
  if [[ ${warnings} -gt 0 ]]; then
    add_vote_table -1 hbaseanti "" "The patch appears use Hadoop classification instead of HBase: ${warnings}."
    ((result=result+1))
  fi
{code}

That should have been a "grep -c" and not a "grep". So we've been falsely giving a negative on all these checks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)