You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ege-st (via GitHub)" <gi...@apache.org> on 2023/07/11 22:44:07 UTC
[GitHub] [pinot] ege-st opened a new pull request, #11081: Update jackson libraries to 2.13.5
ege-st opened a new pull request, #11081:
URL: https://github.com/apache/pinot/pull/11081
Upgrading Jackson libraries from 2.12.7 to 2.13.5 in order to stay up to date and leverage the most recent improvements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #11081: Update jackson libraries to 2.13.5
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #11081:
URL: https://github.com/apache/pinot/pull/11081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11081: Update jackson libraries to 2.13.5
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11081:
URL: https://github.com/apache/pinot/pull/11081#issuecomment-1631660014
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11081?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11081](https://app.codecov.io/gh/apache/pinot/pull/11081?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b92b1a4) into [master](https://app.codecov.io/gh/apache/pinot/commit/9bb3cbb3d6ebf5a9fcd8a5410a5794aee02c7ee4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9bb3cbb) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11081 +/- ##
==========================================
- Coverage 0.11% 0.11% -0.01%
==========================================
Files 2201 2201
Lines 118091 118122 +31
Branches 17872 17874 +2
==========================================
Hits 137 137
- Misses 117934 117965 +31
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `0.00% <ø> (ø)` | |
| integration1temurin17 | `0.00% <ø> (ø)` | |
| integration1temurin20 | `0.00% <ø> (ø)` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `0.00% <ø> (ø)` | |
| unittests1temurin11 | `0.00% <ø> (ø)` | |
| unittests1temurin17 | `0.00% <ø> (ø)` | |
| unittests1temurin20 | `0.00% <ø> (ø)` | |
| unittests2temurin11 | `0.11% <ø> (-0.01%)` | :arrow_down: |
| unittests2temurin17 | `0.11% <ø> (-0.01%)` | :arrow_down: |
| unittests2temurin20 | `0.11% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11081/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ege-st commented on a diff in pull request #11081: Update jackson libraries to 2.13.5
Posted by "ege-st (via GitHub)" <gi...@apache.org>.
ege-st commented on code in PR #11081:
URL: https://github.com/apache/pinot/pull/11081#discussion_r1260367177
##########
pom.xml:
##########
@@ -738,7 +737,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>${jackson-databind.version}</version>
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] soumitra-st commented on a diff in pull request #11081: Update jackson libraries to 2.13.5
Posted by "soumitra-st (via GitHub)" <gi...@apache.org>.
soumitra-st commented on code in PR #11081:
URL: https://github.com/apache/pinot/pull/11081#discussion_r1260363329
##########
pom.xml:
##########
@@ -738,7 +737,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>${jackson-databind.version}</version>
Review Comment:
If jackson-databind is part of the jackson-bom, then additional dependency is not needed, can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ege-st closed pull request #11081: Update jackson libraries to 2.13.5
Posted by "ege-st (via GitHub)" <gi...@apache.org>.
ege-st closed pull request #11081: Update jackson libraries to 2.13.5
URL: https://github.com/apache/pinot/pull/11081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org