[impala] branch master updated: IMPALA-11706: Unlimit Pytest failures for precommit

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 08a127958 IMPALA-11706: Unlimit Pytest failures for precommit
08a127958 is described below

commit 08a127958fddcddec649c0b3f65c0183ee6d5a90
Author: Joe McDonnell <jo...@cloudera.com>
AuthorDate: Fri Nov 4 16:26:07 2022 -0700

    IMPALA-11706: Unlimit Pytest failures for precommit
    
    The change for IMPALA-11569 modified all-tests.sh
    to run bin/bootstrap_development.sh rather than
    sourcing it. That means the environment variables
    defined in bin/bootstrap_development.sh no longer
    apply to all-tests.sh, and thus precommit. In
    particular, MAX_PYTEST_FAILURES is no longer set
    to zero, so the default of MAX_PYTEST_FAILURES=10
    applies. This is too low.
    
    This sets MAX_PYTEST_FAILURES=0 in all-tests.sh to
    allow unlimited pytest failures. This also bumps
    the default MAX_PYTEST_FAILURES from 10 to 100.
    
    Change-Id: I38209fa357ab4edb4c8730fc2186a84a8eefda0d
    Reviewed-on: http://gerrit.cloudera.org:8080/19208
    Reviewed-by: Quanlong Huang <hu...@gmail.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 bin/jenkins/all-tests.sh | 2 ++
 bin/run-all-tests.sh     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/bin/jenkins/all-tests.sh b/bin/jenkins/all-tests.sh
index c6a4e9a9c..7ebe294eb 100644
--- a/bin/jenkins/all-tests.sh
+++ b/bin/jenkins/all-tests.sh
@@ -25,6 +25,8 @@ setup_report_build_error
 cd "${IMPALA_HOME}"
 
 export IMPALA_MAVEN_OPTIONS="-U"
+# Allow unlimited pytest failures
+export MAX_PYTEST_FAILURES=0
 
 # When UBSAN_FAIL is "death", the logs are monitored for UBSAN errors. Any errors will
 # then cause this script to exit.
diff --git a/bin/run-all-tests.sh b/bin/run-all-tests.sh
index f90d6f1bc..7877766a4 100755
--- a/bin/run-all-tests.sh
+++ b/bin/run-all-tests.sh
@@ -28,7 +28,7 @@ setup_report_build_error
 # Allow picking up strategy from environment
 : ${EXPLORATION_STRATEGY:=core}
 : ${NUM_TEST_ITERATIONS:=1}
-: ${MAX_PYTEST_FAILURES:=10}
+: ${MAX_PYTEST_FAILURES:=100}
 : ${TIMEOUT_FOR_RUN_ALL_TESTS_MINS:=1200}
 KERB_ARGS=""