[GitHub] spark pull request: SPARK-2869 - Fix tiny bug in JdbcRdd for closi...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1792#discussion_r15843358
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
    @@ -106,7 +106,7 @@ class JdbcRDD[T: ClassTag](
             case e: Exception => logWarning("Exception closing statement", e)
           }
           try {
    -        if (null != conn && ! stmt.isClosed()) conn.close()
    +        if (null != conn && ! conn.isClosed()) conn.close()
    --- End diff --
    
    while you are at it, do you mind adding curly braces for the close()? The spark coding style requires curly braces even for one-liner ifs. It's an oversight that we didn't do this for the ifs in this file.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org