You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/02/08 13:36:31 UTC
[GitHub] zeppelin pull request #1992: ZEPPELIN-2053: default interpreter list should ...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/1992
ZEPPELIN-2053: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
### What is this PR for?
ZEPPELIN-2053: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2053](https://issues.apache.org/jira/browse/ZEPPELIN-2053)
### How should this be tested?
Remove default spark interpreter, and and another with a different name say "spark2". This newly created interpreter should show up on top.
### Screenshots (if appropriate)
Before:
<img width="1439" alt="screen shot 2017-02-08 at 6 58 09 pm" src="https://cloud.githubusercontent.com/assets/674497/22739380/66c50e72-ee31-11e6-83cc-07669d292a12.png">
After:
<img width="1434" alt="screen shot 2017-02-08 at 6 56 42 pm" src="https://cloud.githubusercontent.com/assets/674497/22739379/66c377d8-ee31-11e6-965c-f9f61b288d99.png">
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2053
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1992
----
commit b17d9bdd038406183cd27661a48a0fe91e2ff110
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-08T13:33:01Z
ZEPPELIN-2053: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1992
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1992
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1992: ZEPPELIN-2083: default interpreter list should ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
GitHub user prabhjyotsingh reopened a pull request:
https://github.com/apache/zeppelin/pull/1992
ZEPPELIN-2083: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
### What is this PR for?
Default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2083](https://issues.apache.org/jira/browse/ZEPPELIN-2083)
### How should this be tested?
Remove default spark interpreter, and and another with a different name say "spark2". This newly created interpreter should show up on top.
### Screenshots (if appropriate)
Before:
<img width="1439" alt="screen shot 2017-02-08 at 6 58 09 pm" src="https://cloud.githubusercontent.com/assets/674497/22739380/66c50e72-ee31-11e6-83cc-07669d292a12.png">
After:
<img width="1434" alt="screen shot 2017-02-08 at 6 56 42 pm" src="https://cloud.githubusercontent.com/assets/674497/22739379/66c377d8-ee31-11e6-965c-f9f61b288d99.png">
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2053
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1992
----
commit b17d9bdd038406183cd27661a48a0fe91e2ff110
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-02-08T13:33:01Z
ZEPPELIN-2053: default interpreter list should honour order of zeppelin.interpreters property in zeppelin-site.xml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1992
@Leemoonsoo can you help review this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1992: ZEPPELIN-2083: default interpreter list should honour ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1992
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1992: ZEPPELIN-2083: default interpreter list should ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh closed the pull request at:
https://github.com/apache/zeppelin/pull/1992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1992: ZEPPELIN-2083: default interpreter list should ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1992
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---