You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/07/22 05:16:18 UTC
Review Request: Implemented JNI bindings for a Java based State (that only
provides byte[] based variables, for now).
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6077/
-----------------------------------------------------------
Review request for mesos, John Sirois and Florian Leibert.
Description
-------
See summary.
Diffs
-----
src/Makefile.am 10f1101
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION
src/java/src/org/apache/mesos/state/State.java PRE-CREATION
src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION
src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION
Diff: https://reviews.apache.org/r/6077/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request: Implemented JNI bindings for a Java based State (that
only provides byte[] based variables, for now).
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On July 22, 2012, 4:38 p.m., John Sirois wrote:
> > src/java/src/org/apache/mesos/state/ZooKeeperState.java, line 40
> > <https://reviews.apache.org/r/6077/diff/3/?file=125942#file125942line40>
> >
> > s/ZooKeeperServer/ZooKeeperState/ both constructor docs.
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6077/#review9348
-----------------------------------------------------------
On July 22, 2012, 3:21 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6077/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 3:21 a.m.)
>
>
> Review request for mesos, John Sirois and Florian Leibert.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 10f1101
> src/java/jni/org_apache_mesos_state_Variable.cpp PRE-CREATION
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION
> src/java/src/org/apache/mesos/state/State.java PRE-CREATION
> src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION
> src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6077/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Implemented JNI bindings for a Java based State (that
only provides byte[] based variables, for now).
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6077/#review9348
-----------------------------------------------------------
Ship it!
src/java/src/org/apache/mesos/state/ZooKeeperState.java
<https://reviews.apache.org/r/6077/#comment20081>
s/ZooKeeperServer/ZooKeeperState/ both constructor docs.
- John Sirois
On July 22, 2012, 3:21 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6077/
> -----------------------------------------------------------
>
> (Updated July 22, 2012, 3:21 a.m.)
>
>
> Review request for mesos, John Sirois and Florian Leibert.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 10f1101
> src/java/jni/org_apache_mesos_state_Variable.cpp PRE-CREATION
> src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION
> src/java/src/org/apache/mesos/state/State.java PRE-CREATION
> src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION
> src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/6077/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Implemented JNI bindings for a Java based State (that
only provides byte[] based variables, for now).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6077/
-----------------------------------------------------------
(Updated July 22, 2012, 3:21 a.m.)
Review request for mesos, John Sirois and Florian Leibert.
Changes
-------
Added a missing file.
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 10f1101
src/java/jni/org_apache_mesos_state_Variable.cpp PRE-CREATION
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION
src/java/src/org/apache/mesos/state/State.java PRE-CREATION
src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION
src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION
Diff: https://reviews.apache.org/r/6077/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request: Implemented JNI bindings for a Java based State (that
only provides byte[] based variables, for now).
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6077/
-----------------------------------------------------------
(Updated July 22, 2012, 3:19 a.m.)
Review request for mesos, John Sirois and Florian Leibert.
Changes
-------
Added 'finalize' for Variable.
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 10f1101
src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp PRE-CREATION
src/java/src/org/apache/mesos/state/State.java PRE-CREATION
src/java/src/org/apache/mesos/state/Variable.java PRE-CREATION
src/java/src/org/apache/mesos/state/ZooKeeperState.java PRE-CREATION
Diff: https://reviews.apache.org/r/6077/diff/
Testing
-------
Thanks,
Benjamin Hindman