You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by Samisa Abeysinghe <sa...@gmail.com> on 2006/01/25 02:37:17 UTC
Re: [AXIS2C] install folder
Damitha Kumarage wrote:
> Hi,
> Please have the install folder structure as in the attachement for
> testing
> purposes.
> Set your AXIS2C_HOME to this folder.
> thanks
> damitha
Damitha,
Is there any way that we could do away with the env variable?
Also, can we get the service samples to be make installed into the
reapective deploy/services folder directly? At the moment it gets
installed to deploy/lib and the users have to copy to deploy/services.
This is a nuance, I suppose we can get the make to install to the
deploy/services directly, but not sure how to do that.
Thanks,
Samisa...
Re: [Axis2] File name and line number in log messages
Posted by Samisa Abeysinghe <sa...@gmail.com>.
Nabeel wrote:
> Yes..correct; should set the __FILE__ and __LINE__ macros to
> AXIS2_LOG_WRITE macro
>
> in axis2_log.h
> #define AXIS2_LOG_WRITE(log, buffer, level) ((log)->ops->write(log,
> buffer, level,__FILE__,__LINE__))
>
> in log.c
>
> axis2_status_t AXIS2_CALL
> axis2_log_impl_write (struct axis2_log *log, const axis2_char_t
> *buffer, axis2_log_levels_t level,char *fn,int ln)
> {
> ...
> fprintf(stderr,"%s%s(%d) %s\n", level_str,fn,ln,buffer);
> }
Yep, may be we could provide an interface to do this in log ops struct
interface.
Thanks,
Samisa...
>
> - Nabeel
>
>
> Samisa Abeysinghe wrote:
>
>> Nabeel wrote:
>>
>>> The following change to log.c:axis2_log_impl_write() fn would log
>>> the line number and file name along with the error msg
>>>
>>> /*fprintf (stderr, "%s", level_str);*/
>>> /*fprintf (stderr, "%s\n", buffer);*/
>>> fprintf(stderr,"%s%s(%d) %s\n", level_str,__FILE__,__LINE__,buffer);
>>
>>
>>
>> I am afraid not. Then it will laways log the line number of loc.c
>> file :(
>> e.g.
>> [info] log.c(96) axis2_handler_t *addressing_based_dispatcher added
>> to the index 0 of the phase Dispatch
>> [info] log.c(96) axis2_handler_t *request_uri_based_dispatcher added
>> to the index 1 of the phase Dispatch
>> [info] log.c(96) axis2_handler_t *soap_action_based_dispatcher added
>> to the index 2 of the phase Dispatch
>> [info] log.c(96) axis2_handler_t *soap_message_body_based_dispatcher
>> added to the index 3 of the phase Dispatch
>> [info] log.c(96) axis2_handler_t *dispatch_post_conditions_evaluator
>> added to the index 0 of the phase PostDispatch
>> [info] log.c(96) axis2_handler_t *context_handler added to the index
>> 1 of the phase PostDispatch
>>
>> You have to use __FILE__ and __LINE__ from the respective source file
>> and pass that to log.c
>>
>> Samisa...
>>
>>>
>>> - Nabeel
>>>
>>> Samisa Abeysinghe wrote:
>>>
>>>> Hi All,
>>>> It is useful to have file name and number info in some log
>>>> messages. As an example, debug level log messages must have this to
>>>> help find where it went wrong.
>>>> I get the following debug messages from simple axis server when
>>>> testing and I have no clue on where they came from:
>>>> [debug] AXIS2_XML_READER_START_ELEMENT
>>>> [debug] identified soap version is soap12
>>>> [debug] AXIS2_XML_READER_SPACE
>>>> [debug] AXIS2_XML_READER_START_ELEMENT
>>>> [debug] AXIS2_XML_READER_SPACE
>>>> [debug] AXIS2_XML_READER_END_ELEMENT
>>>> [debug] AXIS2_XML_READER_SPACE
>>>> [debug] AXIS2_XML_READER_END_ELEMENT
>>>>
>>>> Also, just poping up the error code in the log makes no sense.
>>>> We need more details, human readable and understandable message
>>>> into the log.
>>>>
>>>> Please help fix this.
>>>> Thanks,
>>>> Samisa...
>>>>
>>>
>>>
>>
>>
>
>
Re: [Axis2] File name and line number in log messages
Posted by Nabeel <na...@wso2.com>.
Yes..correct; should set the __FILE__ and __LINE__ macros to
AXIS2_LOG_WRITE macro
in axis2_log.h
#define AXIS2_LOG_WRITE(log, buffer, level) ((log)->ops->write(log,
buffer, level,__FILE__,__LINE__))
in log.c
axis2_status_t AXIS2_CALL
axis2_log_impl_write (struct axis2_log *log, const axis2_char_t *buffer,
axis2_log_levels_t level,char *fn,int ln)
{
...
fprintf(stderr,"%s%s(%d) %s\n", level_str,fn,ln,buffer);
}
- Nabeel
Samisa Abeysinghe wrote:
> Nabeel wrote:
>
>> The following change to log.c:axis2_log_impl_write() fn would log the
>> line number and file name along with the error msg
>>
>> /*fprintf (stderr, "%s", level_str);*/
>> /*fprintf (stderr, "%s\n", buffer);*/
>> fprintf(stderr,"%s%s(%d) %s\n", level_str,__FILE__,__LINE__,buffer);
>
>
> I am afraid not. Then it will laways log the line number of loc.c file :(
> e.g.
> [info] log.c(96) axis2_handler_t *addressing_based_dispatcher added to
> the index 0 of the phase Dispatch
> [info] log.c(96) axis2_handler_t *request_uri_based_dispatcher added
> to the index 1 of the phase Dispatch
> [info] log.c(96) axis2_handler_t *soap_action_based_dispatcher added
> to the index 2 of the phase Dispatch
> [info] log.c(96) axis2_handler_t *soap_message_body_based_dispatcher
> added to the index 3 of the phase Dispatch
> [info] log.c(96) axis2_handler_t *dispatch_post_conditions_evaluator
> added to the index 0 of the phase PostDispatch
> [info] log.c(96) axis2_handler_t *context_handler added to the index 1
> of the phase PostDispatch
>
> You have to use __FILE__ and __LINE__ from the respective source file
> and pass that to log.c
>
> Samisa...
>
>>
>> - Nabeel
>>
>> Samisa Abeysinghe wrote:
>>
>>> Hi All,
>>> It is useful to have file name and number info in some log
>>> messages. As an example, debug level log messages must have this to
>>> help find where it went wrong.
>>> I get the following debug messages from simple axis server when
>>> testing and I have no clue on where they came from:
>>> [debug] AXIS2_XML_READER_START_ELEMENT
>>> [debug] identified soap version is soap12
>>> [debug] AXIS2_XML_READER_SPACE
>>> [debug] AXIS2_XML_READER_START_ELEMENT
>>> [debug] AXIS2_XML_READER_SPACE
>>> [debug] AXIS2_XML_READER_END_ELEMENT
>>> [debug] AXIS2_XML_READER_SPACE
>>> [debug] AXIS2_XML_READER_END_ELEMENT
>>>
>>> Also, just poping up the error code in the log makes no sense. We
>>> need more details, human readable and understandable message into
>>> the log.
>>>
>>> Please help fix this.
>>> Thanks,
>>> Samisa...
>>>
>>
>>
>
>
Re: [Axis2] File name and line number in log messages
Posted by Samisa Abeysinghe <sa...@gmail.com>.
Nabeel wrote:
> The following change to log.c:axis2_log_impl_write() fn would log the
> line number and file name along with the error msg
>
> /*fprintf (stderr, "%s", level_str);*/
> /*fprintf (stderr, "%s\n", buffer);*/
> fprintf(stderr,"%s%s(%d) %s\n", level_str,__FILE__,__LINE__,buffer);
I am afraid not. Then it will laways log the line number of loc.c file :(
e.g.
[info] log.c(96) axis2_handler_t *addressing_based_dispatcher added to
the index 0 of the phase Dispatch
[info] log.c(96) axis2_handler_t *request_uri_based_dispatcher added to
the index 1 of the phase Dispatch
[info] log.c(96) axis2_handler_t *soap_action_based_dispatcher added to
the index 2 of the phase Dispatch
[info] log.c(96) axis2_handler_t *soap_message_body_based_dispatcher
added to the index 3 of the phase Dispatch
[info] log.c(96) axis2_handler_t *dispatch_post_conditions_evaluator
added to the index 0 of the phase PostDispatch
[info] log.c(96) axis2_handler_t *context_handler added to the index 1
of the phase PostDispatch
You have to use __FILE__ and __LINE__ from the respective source file
and pass that to log.c
Samisa...
>
> - Nabeel
>
> Samisa Abeysinghe wrote:
>
>> Hi All,
>> It is useful to have file name and number info in some log
>> messages. As an example, debug level log messages must have this to
>> help find where it went wrong.
>> I get the following debug messages from simple axis server when
>> testing and I have no clue on where they came from:
>> [debug] AXIS2_XML_READER_START_ELEMENT
>> [debug] identified soap version is soap12
>> [debug] AXIS2_XML_READER_SPACE
>> [debug] AXIS2_XML_READER_START_ELEMENT
>> [debug] AXIS2_XML_READER_SPACE
>> [debug] AXIS2_XML_READER_END_ELEMENT
>> [debug] AXIS2_XML_READER_SPACE
>> [debug] AXIS2_XML_READER_END_ELEMENT
>>
>> Also, just poping up the error code in the log makes no sense. We
>> need more details, human readable and understandable message into the
>> log.
>>
>> Please help fix this.
>> Thanks,
>> Samisa...
>>
>
>
Re: [Axis2] File name and line number in log messages
Posted by Nabeel <na...@wso2.com>.
The following change to log.c:axis2_log_impl_write() fn would log the
line number and file name along with the error msg
/*fprintf (stderr, "%s", level_str);*/
/*fprintf (stderr, "%s\n", buffer);*/
fprintf(stderr,"%s%s(%d) %s\n", level_str,__FILE__,__LINE__,buffer);
- Nabeel
Samisa Abeysinghe wrote:
> Hi All,
> It is useful to have file name and number info in some log
> messages. As an example, debug level log messages must have this to
> help find where it went wrong.
> I get the following debug messages from simple axis server when
> testing and I have no clue on where they came from:
> [debug] AXIS2_XML_READER_START_ELEMENT
> [debug] identified soap version is soap12
> [debug] AXIS2_XML_READER_SPACE
> [debug] AXIS2_XML_READER_START_ELEMENT
> [debug] AXIS2_XML_READER_SPACE
> [debug] AXIS2_XML_READER_END_ELEMENT
> [debug] AXIS2_XML_READER_SPACE
> [debug] AXIS2_XML_READER_END_ELEMENT
>
> Also, just poping up the error code in the log makes no sense. We
> need more details, human readable and understandable message into the
> log.
>
> Please help fix this.
> Thanks,
> Samisa...
>
[Axis2] File name and line number in log messages
Posted by Samisa Abeysinghe <sa...@gmail.com>.
Hi All,
It is useful to have file name and number info in some log messages.
As an example, debug level log messages must have this to help find
where it went wrong.
I get the following debug messages from simple axis server when
testing and I have no clue on where they came from:
[debug] AXIS2_XML_READER_START_ELEMENT
[debug] identified soap version is soap12
[debug] AXIS2_XML_READER_SPACE
[debug] AXIS2_XML_READER_START_ELEMENT
[debug] AXIS2_XML_READER_SPACE
[debug] AXIS2_XML_READER_END_ELEMENT
[debug] AXIS2_XML_READER_SPACE
[debug] AXIS2_XML_READER_END_ELEMENT
Also, just poping up the error code in the log makes no sense. We
need more details, human readable and understandable message into the log.
Please help fix this.
Thanks,
Samisa...
[Axis2] Clean up, tidy up and group error codes
Posted by Samisa Abeysinghe <sa...@gmail.com>.
Hi All,
Inspired by a point made by Nabeel, we have to organize the current
error code set.
Given that we have to expose some of the error codes to the user to
be used at service skeletons and client stubs, we need to have a clear
way of making the error codes distingushable from each other and also
help with locating the error codes with ease.
Some of the error codes we are using now are quite ambiguous. e.g.
AXIS2_ERROR_NULL_BODY. I am not sure if this is a SOAP body related
error or HTTP POST request body related error :(
So lets group the error codes by module and come up with a naming
convention:
AXIS2_ERROR_[module name in all capitals]_ERROR_CODE_NAME
for common errors like OUT_OF_MEMORY, we may use SYSTEM in place of
[module name in all capitals].
We need the help from all the folks who put the errors in error.h
to fix this situation as we have around 200 error codes now. So please
look after the error codes you have put into the header. Lets use a
comment to indicate the error groups. e.g.
/***** OM related error codes *****/
/** Document root is NULL, when it is not supposed to be NULL */
AXIS2_ERROR_OM_INVALID_DOCUMENT_STATE_ROOT_NULL.
/***** SOAP related error codes ****/
/** only one SOAP fault allowed in SOAP body */
AXIS2_ERROR_SOAP_ONLY_ONE_SOAP_FAULT_ALLOWED_IN_BODY,
NOTE: grouping the current error codes and changing their order would
not have an impact on error message setting logic. Please see error.c
for details.
Thanks,
Samisa...
Re: [AXIS2C] install folder
Posted by Anuradha Ratnaweera <gn...@gmail.com>.
On 1/30/06, Damitha Kumarage <da...@gmail.com> wrote:
>
> deploy folder I mentioned does not have anything to do with the
> distribution we plan to make.
My mail was a +1 for your approach, and not to change it to bring
unnecessary `alike-ness' between C _installation_ and Java
_deployment_... ;-) And I am glad it's going to be the case.
However, my suggestions for the library name (libaxis2.{a,la.so}) and
include file location still holds.
Anuradha
--
http://www.linux.lk/~anuradha/
http://anuradha-ratnaweera.blogspot.com
Re: [AXIS2C] install folder
Posted by Damitha Kumarage <da...@gmail.com>.
Hi Anuradha,
Anuradha Ratnaweera wrote:
>On 1/27/06, Damitha Kumarage <da...@gmail.com> wrote:
>
>
>>deploy is just a sample directory in our source tree to represent
>>the install directory. When we do make install in source it is
>>installed in the path specified as configure prefix...
>>
>>
>
>+1 for keeping the prefix approach. IMHO, the ideal installation
>would look like the following, which will make axis2 not look out of
>the place among other well established C programs.
>
>- User sets the --prefix, which defaults to /usr/local/, but software
>distributions (RPM, DPKG, emerge etc) make it default to /usr. lib/,
>include/ and bin/ should be created inside prefix.
>
>- Libraries (*.so, *.la and *.a files) *should* be installed to lib/
>directory inside prefix. If prefix is /usr/local/, then this will be
>/usr/local/lib/.
>
>- The best names for the axis 2 library would be libaxis2.la,
>libaxis2.a, libaxis2.so. If it is defined as lib_LTLIBRARIES =
>libaxis2.la, everything else should be looked after properly. With
>the default prefix, you will get /usr/local/lib/libaxis2.{a,la,so}.
>None of the C libraries I have seen have a "_deployment" part... ;-)
>
>
deploy folder I mentioned does not have anything to do with the
distribution we plan to
make. It is just a test install folder that we prefix to in our
build.sh script. Anybody
can safely ignore our build.sh script.
AXIS2C_HOME=`pwd`/deploy
./configure --prefix=${AXIS2C_HOME}
thanks
damitha
>- Header files *should* go into include/ directory inside prefix. But
>since the number of header files are large and as they are specific to
>axis2, general practice is to create a subdirectory (just go through
>/usr/include/ to see how true this is). So, the best option is to
>install them into include/axis2/. If the same can be done to the
>source tree (move include/*.h into include/axis2/, test programs will
>find it easy).
>
>- Test programs are generally not installed. A typical installation
>should look like:
>
> ./configure
> make
> make test # optional
> make install
> make clean # optional
>
>Running make can build test programs, but make test can look after
>running them and see if they really work.
>
> Anuradha
>--
>http://www.linux.lk/~anuradha/
>http://anuradha-ratnaweera.blogspot.com
>
>
Re: [AXIS2C] install folder
Posted by Damitha Kumarage <da...@gmail.com>.
Anuradha Ratnaweera wrote:
>On 1/27/06, Damitha Kumarage <da...@gmail.com> wrote:
>
>
>>deploy is just a sample directory in our source tree to represent
>>the install directory. When we do make install in source it is
>>installed in the path specified as configure prefix...
>>
>>
>
>+1 for keeping the prefix approach. IMHO, the ideal installation
>would look like the following, which will make axis2 not look out of
>the place among other well established C programs.
>
>- User sets the --prefix, which defaults to /usr/local/, but software
>distributions (RPM, DPKG, emerge etc) make it default to /usr. lib/,
>include/ and bin/ should be created inside prefix.
>
>- Libraries (*.so, *.la and *.a files) *should* be installed to lib/
>directory inside prefix. If prefix is /usr/local/, then this will be
>/usr/local/lib/.
>
>- The best names for the axis 2 library would be libaxis2.la,
>libaxis2.a, libaxis2.so. If it is defined as lib_LTLIBRARIES =
>libaxis2.la, everything else should be looked after properly. With
>the default prefix, you will get /usr/local/lib/libaxis2.{a,la,so}.
>None of the C libraries I have seen have a "_deployment" part... ;-)
>
>- Header files *should* go into include/ directory inside prefix. But
>since the number of header files are large and as they are specific to
>axis2, general practice is to create a subdirectory (just go through
>/usr/include/ to see how true this is). So, the best option is to
>install them into include/axis2/. If the same can be done to the
>source tree (move include/*.h into include/axis2/, test programs will
>find it easy).
>
>
+1 to have include/axis2
>- Test programs are generally not installed. A typical installation
>
>
true, instead we should install our samples. isn't it?
>should look like:
>
> ./configure
> make
> make test # optional
>
> make install
> make clean # optional
>
>
>Running make can build test programs, but make test can look after
>running them and see if they really work.
>
>
I guesss make test can run all our unit tests and system tests and
verify that
everything is ok. If that is so let's do it ASAP which will make the
life so much
easy :)
thanks
damitha
> Anuradha
>--
>http://www.linux.lk/~anuradha/
>http://anuradha-ratnaweera.blogspot.com
>
>
Re: [AXIS2C] install folder
Posted by Anuradha Ratnaweera <gn...@gmail.com>.
On 1/27/06, Damitha Kumarage <da...@gmail.com> wrote:
>
> deploy is just a sample directory in our source tree to represent
> the install directory. When we do make install in source it is
> installed in the path specified as configure prefix...
+1 for keeping the prefix approach. IMHO, the ideal installation
would look like the following, which will make axis2 not look out of
the place among other well established C programs.
- User sets the --prefix, which defaults to /usr/local/, but software
distributions (RPM, DPKG, emerge etc) make it default to /usr. lib/,
include/ and bin/ should be created inside prefix.
- Libraries (*.so, *.la and *.a files) *should* be installed to lib/
directory inside prefix. If prefix is /usr/local/, then this will be
/usr/local/lib/.
- The best names for the axis 2 library would be libaxis2.la,
libaxis2.a, libaxis2.so. If it is defined as lib_LTLIBRARIES =
libaxis2.la, everything else should be looked after properly. With
the default prefix, you will get /usr/local/lib/libaxis2.{a,la,so}.
None of the C libraries I have seen have a "_deployment" part... ;-)
- Header files *should* go into include/ directory inside prefix. But
since the number of header files are large and as they are specific to
axis2, general practice is to create a subdirectory (just go through
/usr/include/ to see how true this is). So, the best option is to
install them into include/axis2/. If the same can be done to the
source tree (move include/*.h into include/axis2/, test programs will
find it easy).
- Test programs are generally not installed. A typical installation
should look like:
./configure
make
make test # optional
make install
make clean # optional
Running make can build test programs, but make test can look after
running them and see if they really work.
Anuradha
--
http://www.linux.lk/~anuradha/
http://anuradha-ratnaweera.blogspot.com
Re: [AXIS2C] install folder
Posted by Damitha Kumarage <da...@gmail.com>.
Hi Deepal,
Samisa Abeysinghe wrote:
> Deepal Jayasinghe wrote:
>
>> Hi Samisa ;
>>
>> is deploy directory is same as Axis2 java repository directory ? , if
>> we can have same terminology for both Axis2 C and Axis2 Java that
>> will be great ,
>
deploy is just a sample directory in our source tree to represent
the install directory. When we do make install in source it is
installed in the path specified as configure prefix, with the folder
name axis2c. this axis2c directory is comparable to your webapps/axis2
directory.
Yes we can have the same terminology "repository" for this folder. When
we start simple axis server we give the path
to this repository directory as repository path.
thanks
damitha
>
> Yes it is the same. Not a bad suggestion :) Damitha, what do you think?
>
> Samisa...
>
>>
>> this is just suggestion :)
>>
>> Thanks,
>> Deepal
>> ................................................................
>> ~Future is Open~
>>
>> ----- Original Message ----- From: "Samisa Abeysinghe"
>> <sa...@gmail.com>
>> To: <ax...@ws.apache.org>
>> Sent: Wednesday, January 25, 2006 7:37 AM
>> Subject: Re: [AXIS2C] install folder
>>
>>
>>> Damitha Kumarage wrote:
>>>
>>>> Hi,
>>>> Please have the install folder structure as in the attachement for
>>>> testing
>>>> purposes.
>>>> Set your AXIS2C_HOME to this folder.
>>>> thanks
>>>> damitha
>>>
>>>
>>>
>>> Damitha,
>>> Is there any way that we could do away with the env variable?
>>>
>>> Also, can we get the service samples to be make installed into the
>>> reapective deploy/services folder directly? At the moment it gets
>>> installed to deploy/lib and the users have to copy to
>>> deploy/services. This is a nuance, I suppose we can get the make to
>>> install to the deploy/services directly, but not sure how to do that.
>>>
>>> Thanks,
>>> Samisa...
>>>
>>>
>>>
>>
>>
>
>
Re: [AXIS2C] install folder
Posted by Samisa Abeysinghe <sa...@gmail.com>.
Deepal Jayasinghe wrote:
> Hi Samisa ;
>
> is deploy directory is same as Axis2 java repository directory ? , if
> we can have same terminology for both Axis2 C and Axis2 Java that will
> be great ,
Yes it is the same. Not a bad suggestion :) Damitha, what do you think?
Samisa...
>
> this is just suggestion :)
>
> Thanks,
> Deepal
> ................................................................
> ~Future is Open~
>
> ----- Original Message ----- From: "Samisa Abeysinghe"
> <sa...@gmail.com>
> To: <ax...@ws.apache.org>
> Sent: Wednesday, January 25, 2006 7:37 AM
> Subject: Re: [AXIS2C] install folder
>
>
>> Damitha Kumarage wrote:
>>
>>> Hi,
>>> Please have the install folder structure as in the attachement for
>>> testing
>>> purposes.
>>> Set your AXIS2C_HOME to this folder.
>>> thanks
>>> damitha
>>
>>
>> Damitha,
>> Is there any way that we could do away with the env variable?
>>
>> Also, can we get the service samples to be make installed into the
>> reapective deploy/services folder directly? At the moment it gets
>> installed to deploy/lib and the users have to copy to
>> deploy/services. This is a nuance, I suppose we can get the make to
>> install to the deploy/services directly, but not sure how to do that.
>>
>> Thanks,
>> Samisa...
>>
>>
>>
>
>
Re: [AXIS2C] install folder
Posted by Deepal Jayasinghe <de...@gmail.com>.
Hi Samisa ;
is deploy directory is same as Axis2 java repository directory ? , if we can
have same terminology for both Axis2 C and Axis2 Java that will be great ,
this is just suggestion :)
Thanks,
Deepal
................................................................
~Future is Open~
----- Original Message -----
From: "Samisa Abeysinghe" <sa...@gmail.com>
To: <ax...@ws.apache.org>
Sent: Wednesday, January 25, 2006 7:37 AM
Subject: Re: [AXIS2C] install folder
> Damitha Kumarage wrote:
>
>> Hi,
>> Please have the install folder structure as in the attachement for
>> testing
>> purposes.
>> Set your AXIS2C_HOME to this folder.
>> thanks
>> damitha
>
> Damitha,
> Is there any way that we could do away with the env variable?
>
> Also, can we get the service samples to be make installed into the
> reapective deploy/services folder directly? At the moment it gets
> installed to deploy/lib and the users have to copy to deploy/services.
> This is a nuance, I suppose we can get the make to install to the
> deploy/services directly, but not sure how to do that.
>
> Thanks,
> Samisa...
>
>
>