You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2016/10/06 09:08:20 UTC

[jira] [Resolved] (OAK-4895) FileStore cleanup should not leak out file handles

     [ https://issues.apache.org/jira/browse/OAK-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-4895.
--------------------------------
    Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1763540&view=rev

> FileStore cleanup should not leak out file handles
> --------------------------------------------------
>
>                 Key: OAK-4895
>                 URL: https://issues.apache.org/jira/browse/OAK-4895
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>             Fix For: Segment Tar 0.0.14
>
>
> {{FileStore.cleanup()}} currently returns a list of {{File}} instances relying on the caller to remove those files. This breaks encapsulation as the file store is the sole owner of these files and only the file store should be removing them.
> I suggest to replace the current cleanup method with one that returns {{void}}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)