You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Tim Armstrong (Jira)" <ji...@apache.org> on 2020/06/03 00:06:00 UTC

[jira] [Updated] (IMPALA-9756) Queries are not guaranteed to be cancelled before unregistration

     [ https://issues.apache.org/jira/browse/IMPALA-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong updated IMPALA-9756:
----------------------------------
    Fix Version/s:     (was: 4/)
                   Impala 4.0

> Queries are not guaranteed to be cancelled before unregistration 
> -----------------------------------------------------------------
>
>                 Key: IMPALA-9756
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9756
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.0
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>             Fix For: Impala 4.0
>
>
> I noticed while running TSAN on a branch that it's possible for a query to be unregistered *while* cancellation is in progress, if the cancellation is triggered by a different thread (e.g. a separate client connection) and 
> This is because ClientRequestState::Cancel() will return early if cancellation was already started, and ImpalaServer::Unregister() will proceed. 
> I think the main consequence of this is that the profile may be missing information that is added during cancellation (ComputeQuerySummary(), etc), but it generally makes the code more racy and bugs more likely.
> Instead Finalize() should wait for the cancellation to finish in the other thread before proceeding.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org