You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/29 13:45:32 UTC

[GitHub] [incubator-devlake] e2corporation commented on pull request #3247: fix: config-ui: prevent autofill of passwords on new connection form

e2corporation commented on PR #3247:
URL: https://github.com/apache/incubator-devlake/pull/3247#issuecomment-1262308097

   > ![image](https://user-images.githubusercontent.com/3294100/192924238-12dd3ef4-04a6-4ac2-b1af-2070d5b8eea6.png)
   > 
   > 'new-password' seems new password will show. And I find autoComplete="false" used in some other codes. Let's fix all of these in one PR?
   
   I think i covered all the uses of `autoComplete`, _except_ for the `GenerateTokenForm` which is a legacy component for when we offered Base64 encoding for JIRA so that component is not actively being used at the moment so I didn't change it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org