[GitHub] [phoenix] dbwong commented on a change in pull request #630: PHOENIX-5545: DropChildViews Task fails for a base table when its child view has an index

[GitBox <gi...@apache.org>]

dbwong commented on a change in pull request #630: PHOENIX-5545: DropChildViews Task fails for a base table when its child view has an index
URL: https://github.com/apache/phoenix/pull/630#discussion_r345974115
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewMetadataIT.java
 ##########
 @@ -186,7 +190,8 @@ public void testCreateViewMappedToExistingHbaseTableWithNamespaceMappingEnabled(
 
             // test for a view that is in non-default schema
             {
-                HTableDescriptor desc = new HTableDescriptor(TableName.valueOf(NS, TBL));
+                tableName = TableName.valueOf(NS, TBL);
 
 Review comment:
   Why did we move the declarations out of the block?  I'm assuming the declarations were local so we would be less likely to have same variable reused with wrong values scenario.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services