[GitHub] [spark] grundprinzip commented on a diff in pull request #39835: [SPARK-42268][CONNECT][PYTHON] Add UserDefinedType in protos

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #39835:
URL: https://github.com/apache/spark/pull/39835#discussion_r1094208220


##########
connector/connect/common/src/main/protobuf/spark/connect/types.proto:
##########
@@ -172,4 +175,12 @@ message DataType {
     bool value_contains_null = 3;
     uint32 type_variation_reference = 4;
   }
+
+  message UDT {
+    string type = 1;
+    optional string jvm_class = 2;
+    optional string python_class = 3;
+    optional string serialized_python_class = 4;
+    DataType sql_type = 5;

Review Comment:
   @HyukjinKwon @zhengruifeng Quick question here, are these class names or serialized data? If data why is this not a `bytes` field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org