You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/07/13 10:17:12 UTC
[GitHub] [cordova-android] erisu opened a new pull request #1272: cleanup: delete old ANT & Eclipse files
erisu opened a new pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272
### Motivation, Context & Description
Remove old ANT/Eclipse related files.
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17ce6f0) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-879034402
I will create a separate PR for removing the VERSION file.
I think that the file was not from ANT nor Eclipse. I think it was something we created to easily manage the cordova-android version in one location and use it in places like ANT. I think it was apart of the pre-npm registry era.
Even through after this PR is merged, there should be no references to this file. I just want to make sure we can easily revert the VERSION drop if there was something unexpected that was not in our radar.
As for ANT & Eclipse, these are outdated tools that isnt genrally used or prefered for Android development/release anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f0522) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 19f0522 differs from pull request most recent head 17ce6f0. Consider uploading reports for the commit 17ce6f0 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17ce6f0) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91f6fc4) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 91f6fc4 differs from pull request most recent head 17ce6f0. Consider uploading reports for the commit 17ce6f0 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f0522) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 19f0522 differs from pull request most recent head 17ce6f0. Consider uploading reports for the commit 17ce6f0 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1272: cleanup: delete old ANT & Eclipse files
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1272:
URL: https://github.com/apache/cordova-android/pull/1272#issuecomment-878965288
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1272](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19f0522) into [master](https://codecov.io/gh/apache/cordova-android/commit/68a302e9d2b9cf428a0decbaf9535f934eeca0d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68a302e) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 19f0522 differs from pull request most recent head 17ce6f0. Consider uploading reports for the commit 17ce6f0 to get more accurate results
[](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 21 21
Lines 1646 1646
=======================================
Hits 1206 1206
Misses 440 440
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [68a302e...17ce6f0](https://codecov.io/gh/apache/cordova-android/pull/1272?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org