[GitHub] [airflow] potiuk edited a comment on issue #20308: Multi Schedulers don't synchronize task instance state when using Triggerer

[GitBox <gi...@apache.org>]

potiuk edited a comment on issue #20308:
URL: https://github.com/apache/airflow/issues/20308#issuecomment-1057869795


   Actually It might, in case Lock is kept as an object in the session. I am not sure what kind of "objects" are kept in the session. Funny thing that statement about in the documentation of SQLAlchemy is a bit ambiguous. I am not a native speaker but IMHO it's not  obvious at all oif "and releases any transactional/connection resources" refers to "close()" or "expunge_all()" method. 
   
   At a first glance, it should be about "close()", but if Locks are represented as objects in the session, expunge_all() might also release locks. WDYT @andrewgodwin @ashb ?
   
   https://docs.sqlalchemy.org/en/14/orm/session_basics.html#closing
   
   > The Session.close() method issues a Session.expunge_all() which removes all ORM-mapped objects from the session, and releases any transactional/connection resources from the Engine object(s) to which it is bound. When connections are returned to the connection pool, transactional state is rolled back as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org