You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/22 05:00:13 UTC

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4690: Fix profile recheck error

kezhenxu94 commented on a change in pull request #4690:
URL: https://github.com/apache/skywalking/pull/4690#discussion_r412670618



##########
File path: test/e2e/e2e-service-provider/src/main/java/test/apache/skywalking/e2e/User.java
##########
@@ -16,7 +16,7 @@
  *
  */
 
-package org.apache.skywalking.e2e;
+package test.apache.skywalking.e2e;

Review comment:
       What does the renaming fix? If it really fixes something, please add the directory to
   
   https://github.com/apache/skywalking/blob/8e6a527f78108c7a466ba2dd87eaf5c47d1765cc/tools/coverage/report.sh#L32-L34
   
   i.e. `sudo rm -rf "${JACOCO_HOME}"/classes/"${exec_data}"/test || true `




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org