You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2015/07/07 02:42:05 UTC
Re: Review Request 35397: Fix Samza-697
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35397/#review90620
-----------------------------------------------------------
The latest diff seems incomplete. Missing some file(s).
- Boris Shkolnik
On June 30, 2015, 6:29 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35397/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 6:29 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-697
> https://issues.apache.org/jira/browse/SAMZA-697
>
>
> Repository: samza
>
>
> Description
> -------
>
> Address Boris and Yi's comments
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml 3374f0c432e61ac4cda275377604cfd481f0cddf
> docs/learn/documentation/versioned/jobs/configuration-table.html 405e2cea4fd1d037cc26b3537f6bb406eded202b
> samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 0b3a235b5ab1d6bd60669bfe6023f6b0b4e943d3
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala cbacd183420e9d1d72b05693b55a8f0a62d59fc5
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala c5a5ea5dea9a950fc741625238f5bf8b1f362180
> samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 1c178a661e449c6bdfc4ce431aef9bb2d261a6c2
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 4fac154709d72ab594485dad93c912b55fb1617e
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 9fb1aa98fcd14397e8a4cb00c67537482e95fa53
> samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 7caad28c9298485753ab861da76793cf925953ed
>
> Diff: https://reviews.apache.org/r/35397/diff/
>
>
> Testing
> -------
>
> unit tests
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 35397: Fix SAMZA-697
Posted by Guozhang Wang <wa...@gmail.com>.
> On July 7, 2015, 12:42 a.m., Boris Shkolnik wrote:
> > The latest diff seems incomplete. Missing some file(s).
Ahh yes. Added the missing files.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35397/#review90620
-----------------------------------------------------------
On July 10, 2015, 4:54 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35397/
> -----------------------------------------------------------
>
> (Updated July 10, 2015, 4:54 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-697
> https://issues.apache.org/jira/browse/SAMZA-697
>
>
> Repository: samza
>
>
> Description
> -------
>
> Add missing files
>
>
> Diffs
> -----
>
> checkstyle/import-control.xml 3374f0c432e61ac4cda275377604cfd481f0cddf
> docs/learn/documentation/versioned/jobs/configuration-table.html 405e2cea4fd1d037cc26b3537f6bb406eded202b
> samza-core/src/main/java/org/apache/samza/task/TaskClassLoader.java PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/config/TaskConfig.scala 0b3a235b5ab1d6bd60669bfe6023f6b0b4e943d3
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala cbacd183420e9d1d72b05693b55a8f0a62d59fc5
> samza-core/src/main/scala/org/apache/samza/container/TaskInstance.scala c5a5ea5dea9a950fc741625238f5bf8b1f362180
> samza-core/src/main/scala/org/apache/samza/job/JobRunner.scala 1c178a661e449c6bdfc4ce431aef9bb2d261a6c2
> samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala 4fac154709d72ab594485dad93c912b55fb1617e
> samza-core/src/test/java/org/apache/samza/task/TestTaskClassLoader.java PRE-CREATION
> samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala 9fb1aa98fcd14397e8a4cb00c67537482e95fa53
> samza-core/src/test/scala/org/apache/samza/container/TestTaskInstance.scala 7caad28c9298485753ab861da76793cf925953ed
>
> Diff: https://reviews.apache.org/r/35397/diff/
>
>
> Testing
> -------
>
> unit tests
>
>
> Thanks,
>
> Guozhang Wang
>
>