[GitHub] [spark] tgravescs commented on a change in pull request #30099: [SPARK-33191][YARN][TESTS] Fix PySpark test cases in YarnClusterSuite

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #30099:
URL: https://github.com/apache/spark/pull/30099#discussion_r508512792



##########
File path: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala
##########
@@ -52,6 +52,13 @@ import org.apache.spark.util.{Utils, YarnContainerInfoHelper}
 @ExtendedYarnTest
 class YarnClusterSuite extends BaseYarnClusterSuite {
 
+  private val pythonExecutablePath = {
+    // To make sure to use the same Python executable.
+    val maybePath = TestUtils.getAbsolutePathFromExecutable("python3")
+    assert(maybePath.isDefined)

Review comment:
       maybe we should have a more descriptive error message if this fails so users can easily figure out what's wrong.
   It also seems like we should have a better way to specify the python executable then hardcoding to python3 in this test, but that isn't something you changed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org